https://nf-co.re logo
Join Slack
Powered by
I was wondering if we should change the way we rep...
# parabricks
f
I was wondering if we should change the way we report versions on the parabricks modules. This is what we get as output:
Copy code
------------------------------------------------------------------------------------------
Version Information
------------------------------------------------------------------------------------------
Tool:			fq2bam
pbrun:			4.5.1-1
------------------------------------------------------------------------------------------
Compatible With:
BWA mem:		0.7.15
Picard:			2.18.25
------------------------------------------------------------------------------------------
I would vote to add the pbrun version but also the compatible with versions to the verions.yml string. What do the other parabricks users think?
m
I'd say we only need 
pbrun 4.5.1-1
compatible versions for me belong in meta.yml or in the docs
f
but then its a pain in the end to understand what the respective tool matches in the CPU architecture
m
not in the versions.yml
f
and if we put it in the meta we need to update it by hand every time we update the module
I agree that the versions.yml is not the perfect place but I want this info to be accessible and not maintaines by hand
m
For me 
versions.yml
reports the tools used the tools compatible with have nothing to do with, and it's more a documentation issue
so the person updating the modules should make an effort into documenting that properly
f
but that means that each update requires like running pbrun --version for each subtool (so around 10 times) and writing this inof down somewhere
m
extra emit channel
f
ok not against that
m
on top of versions.yml we add compatible_versions.yml
or whatever
not to be used in versions collection, but just to snapshot them
and document easilly
we would not even need to document explicitly but mentioning to look for the right string in the snapshot to know the compatibility
👍 1
and when we switch to topics, that won't be an issue at all either
👍 1
f
perfect that seems like a good solution for me
(I am updating the parabricks modules atm and will add that)
m
Wonderful
Ping me please
👍 1
f
m
That was fast
f
yeah missing the snapshots
but for mutectcaller i added the new file
check it out
m
yeah, looking good
I'm wondering since we're reporting versions
f
maybe we can get it a bit nice in formatting
m
should we keep the same structure
shared a GIF
f
just not sure how to
I hate regex string parsing
m
ask AI
f
that never works for me
but ok lets see
@Maxime Garcia I added it as yaml
will do that for all submodules that need it
m
Wonderful
f
Its merged: https://github.com/nf-core/modules/pull/9078, all modules are updated to the latest version and I added the compatible with info to an optional stub output file :)
❤️ 2
m
❤️
Open in Slack
PreviousNext
Powered by