https://nf-co.re logo
Join Slack
Powered by
heads-up: small patch template update incoming tod...
# pipeline-maintainers
m
heads-up: small patch template update incoming today. sorry for the short notice, but these template changes should mostly iron out things we missed with the bigger nf-test introduction. the update/changes will look like this: https://github.com/nf-core/testpipeline/pull/127/commits/c2e8404f026992e856db5d7637f59d978dd6d4ac The only bigger change is the bump of the minimum nextflow version to 24.10.* and nf-schema to 2.4.2
👀 1
m
should there be a sync template PR?
m
Not yet still testing
and the template update is out! Some tiny merge conflicts, but mostly you can accept the changes coming from the template branch and everything should be able to be resolved in the GitHub interface (not 100% why git wasn’t that good with the diffs this time, will investigate) If you see anything weird or are confused about something, please reach out!
m
wonderful
thanks
I'll be trying it out RN
m
some pipelines that don’t have a 
manifest.contributors
entry in the 
dev
branch couldn’t be synced yet. we will work on a fix for that
m
couldn't fix the conflicts on the GH interface, but that's probably because of some deleted files from my side, so all good
👍🏻 1
m
And https://github.com/nf-core/drugresponseeval/pull/55 is the first template PR that got merged, nice work @Judith Bernett! 🎉 (bonus points for funny commit messages 😁)
🙈 2
🎉 3
drugresponseeval2 3
m
Congrats @Judith Bernett, you beat me to it
🤭 1
m
Screenshot 2025-07-08 at 15.32.57.png,a-cartoon-character-from-the-movie-frozen-is-dancing-and-saying-let-it-grow-let-it-grow.gif
👀 1
meow love 1
m
Love the stats bar
l
Good morning, I have updated 
metaval
to the latest nf-core template. Do you know why git actions doesn’t run the 
nf-test-changes
job after the template update? The nf-test changes is in the 
nf-test.yml
file. https://github.com/genomic-medicine-sweden/metaval/pull/54
👀 1
m
I'm assuming you don't have 
runs-on
on the gms org
l
Aha, then how do I fix it?
m
l
Thank you!
m
made some comments on your TEMPLATE sync PR
❤️ 1
l
Should I revert all 
run on
using self-hosted runners in this 
nf-test.yml
? Or should i revert all changes in this file?
m
@Júlia Mir do we pay attention to these custom runners for non nf-core pipeline?
m
Yes, they are not added if nf-core is in skipped_features
🙏 1
👍🏻 1
m
I don't see any skipped_features there
l
So should i just add these two lines to the 
nf-core.yml
file:
Copy code
skipped_features:
  - nf-core
j
should be taken into account already since you have `is_nfcore: false`https://github.com/genomic-medicine-sweden/metaval/blob/dev/.nf-core.yml#L34
👍 1
l
Then what might be causing git actions to skip the 
nf-test-changes
check?
@Sofia Stamouli 👆
Open in Slack
PreviousNext
Powered by