Hey! It looks like something new is broken with th...
# tools
r
Hey! It looks like something new is broken with the AWS megatests. We saw now with a few pipelines that full size tests are either not triggered or triggered from the dev branch instead of the release tag. Is this already fixed in dev? I can go open an issue later when I have time if not. cc @Yuk Kei Wan @Famke Bäuerle @James Fellows Yates @Maxime Garcia
sadpanda 2
ah sorry, Yuk Kei: for yours I think it's expected that the test is skipped.
sadpanda 1
j
fixed in dev 👍🏻
r
The prettier & editorconfig, can they be removed from the GHA?
👍🏻 1
j
but what's the problem of triggered from the dev branch?
it should be triggered from dev when it's triggered by a PR and from the latest tag when it's released
r
for #bamtofastq the release-test for the results for the website was triggered with the dev tag and
results-dev
as the
outdir
j
I think this is because the action was not triggered after release
👍 1
and this is what was now fixed on dev, since a couple of days ago
r
the EditorConfig & prettier action in the nanoseq repo, can they be removed? I don't see them in sarekhttps://github.com/nf-core/nanoseq/settings/branch_protection_rules/6395633
j
yees, we use pre-commit now
r
@Yuk Kei Wan removed the actions that didn't run
y
should I remove awsfulltest.yml?
r
no, I don;t think so
it's fine that the test is skipped here. It is run on release but not every PR 💰
y
should I remove these ones then?
r
they should disappear if you push a new commit
m
we should remove them from the required list in the branch settings
no?
y
I push a new commit, but they are still there? which files should I exactly change?
m
yeah, it's on the branch settings side
@Rike Hanssen I'm on it
r
already deleted it from the branch settings
m
It was there when I mentioned it 4 min ago
I deleted it (too?) and added some required tests for now, but we'll need to udpate
r
huh weird
m
dev
branch?
r
yes maybe i didn't hit save
m
weird
f
As bamtofastq is already released: should we just wait for the next tools release and do a patch release afterwards?
j
You mean to get the results on the website?
f
yes? because I am still not completely sure if I understand what exactly is failing and also why its failing (since everything works locally with both master and dev)
but I am also happy to do it now, I just do not understand what I would need to do haha
r
two issues in the same thread: • issue with how the tests are submitted (pointing to dev instead of the release. We can fix this manually. no need to release here. we should do that so we have the results on the website. • issue with the detection process. Need to figure out why and either patch the pipeline or aws.
👍 1
j
Yeah, so for the first one you can run a manual execution via the actions tab (select left hand menu the 'AWS full test' action, then on that page top right > trigger test > drop down > select tag > select release tag > run
(for Famke's info 🙂 )
sarek spin 1
f
Ok then I would try to run the manual execution on the release tag? Or is that the one that already failed @Maxime Garcia?
r
the one that already failed
😭 1