Since long, for <#C02FC6VFQG1|metatdenovo>, lintin...
# tools
d
Since long, for #metatdenovo, linting at GitHub complains about
assets/nf-core-metatdenovo_logo_light.png
and
docs/images/nf-core-metatdenovo_logo_light.png
not matching the template while local linting does not. See e.g. https://github.com/nf-core/metatdenovo/pull/371.
@nf-core-bot fix linting
does not resolve this. How can I fix this?
Had a similar problem with another file so put this:
Copy code
files_unchanged:
    - .github/PULL_REQUEST_TEMPLATE.md
in the .nf-core.yml file
d
thanks!
p
@Evangelos Karatzas I'm curious about the markdown file, is there something in there that you want to be intentionally different?
@Daniel Lundin having this for the logo is a common problem since we moved logo generation away from the nf-core website and into the local CLI unfortunately. It's due to system-specific differences in how the underlying libraries generate PNGs from SVGs shakefist
There is a way to somehow download the image from the GitHub CI I think (?) and then save that into the repo. Then if it's not generated on your computer then the CI should pass. Or yes, you can just tell the lint test to skip that one, that's also fine.
d
OK, I'll skip. Wouldn't it be better to have this check on the svg original then?
p
I'm not sure that we save the SVG images to the repo at all 🤔
Maybe we should, especially since support for rendering SVGs has improved a lot since we first wrote this code..
Feel free to make a new GitHub issue on #tools about this 🙂
d
OK, I'll do that.
🙏🏻 1
e
There is currently a problem with the auto generated test pipeline and it fails in nfcore linting.