Hi <@U02JS8EFMMJ> <@U0189GFKX47>, brief recap on w...
# crisprseq
m
Hi @Júlia Mir @Laurence Kuhlburger, brief recap on where we stand for the upcoming release: • PR #237 (custom trimming options) is ready for review, could you please take a look and let me know if this can be merged? • PR #239 (test conversion to nf-test), I started this during the hackathon, but some tests are lengthy and I had also other things to do, so the assertion statements are still to do, I will try to complete this as soon as possible, and then if you agree I will change the CI gh workflow to use nf-test instead of the test profiles • PR #235 (the issue with the conda env), I have read your discussion on the PR... is there really something to fix here? • issue #240 (additinal test for bowtie alignment), if I am not mistaken, this is not covered currently in tests, so I will do this when I finish PR #239 • other issues?
l
Hi Matteo, there is also a larger older pr from myself which just needs a few small changes (I am on my phone so don't have the pr #). I will hopefully have it ready within the next week. Then maybe we can include it. Thoughts everyone?
j
Hello! I am starting to review your PRs, sorry for taking a bit longer 😄
regarding #235, I think the changes are still relevant, but the module should be updated in the nf-core/modules repo
I will also have a final look at Leon's PR, https://github.com/nf-core/crisprseq/pull/193 I think it should be good to go and we can include it to the next release 🙂
l
It should be runnable. What I really want to do is get the gpt results into the MultiQC report. That would be great. In case you need a api key for testing let me know i can provide you with a temporary key :)
m
@Leon Hornich great! sorry for not including your PR in the list, but I noticed only yesterday that there was some recent activity in #193 Anyway, there is no hurry, there's plenty I need to do still for #239 and #240 before we can do the release
@Júlia Mir thanks for the feedback on the tests, I still want to include more detailed assertions, at least for the short tests that will be included in the CI workflow, but I am superbusy (work that piled up during the hackathon 😫) so I need a few more days
j
all good, we are all recovering form the hackathon 😂 let me know if you need anything else 🙂
😆 1