https://nf-co.re logo
Join Slack
Powered by
Is there a way for us to test for problems being f...
# linting
s
Is there a way for us to test for problems being flagged by the VSCode language extension? Like this PR by @Rob Syme / @Júlia Mir, to update a subworkflow, now gives an error in VSCode because 
switch
doesn't seem to be supported anymore. https://github.com/nf-core/modules/pull/7129
s
ya I think 
switch
statements are discouraged. maybe the same can be done via the elvis operator 🤔
and ya I had similar thought of some way to lint language server recommendations. like if there are issues -> we have a lint warning
r
I can if-else this PR
this 1
j
From the Nextflow side they are working on a linter which will help us with the language server and fixing the warnings
party this 2
r
I'm just confirming with Ben before I change the PR. I like switch statements. If Ben says no, then I'll change, but will try to keep it as is if possible.
👍 1
s
i also like switch
r
A man of culture
cowboyhat tip 1
Ben may well support switch in the LSP in the future, but for now, I'll revert to if-else to be safe. Fixes here and added some tests for good measure.
✅ 1
❤️ 1
s
Thanks Rob!
👍🏻 1
Open in Slack
PreviousNext
Powered by