Nicolás Alejandro Schcolnicov
11/28/2024, 11:33 AMmashehu
11/28/2024, 12:27 PMArthur
11/28/2024, 1:11 PMArthur
11/28/2024, 1:15 PMCOMPUTEGENESCORES. (Yes it's ugly, yes there are better ways of doing this, no there is no active plan to change nf-core modules to allow underscores in names that I am aware of, changing it would potentially break a lot of nf-core backwards compatibility at this point and require a total tooling overhaul)Sateesh_Peri
11/28/2024, 1:29 PMYou can't have underscores in module names@Arthur not sure if that is true. every tool suite with subtools will have underscores https://github.com/nf-core/methylseq/blob/d16f8f81e812d86f4d297e69de3f001628dfd5b4/modules/nf-core/bismark/methylationextractor/main.nf#L1 or did i misread you ?
Sateesh_Peri
11/28/2024, 1:31 PMnf-core modules lint compute_gene_scores/resources
nf-core modules lint compute_gene_scores/nextflow.configArthur
11/28/2024, 1:53 PM/ would be.
When I look at the PR it seems that the module folder has an underscore in it? That is not allowedArthur
11/28/2024, 2:01 PMtools doesn't throw a warning about this when you run createArthur
11/28/2024, 2:08 PMnf-core/modules? The scripts are somewhat complex, in particular the one that calculates gene scores. I wonder if these would be better published into a package first? (Right now nf-core/modules would be the source for what seems like business logic?)
But that's secondary to the issue at hand - underscores!Sateesh_Peri
11/28/2024, 2:29 PMNicolás Alejandro Schcolnicov
11/28/2024, 2:50 PMArthur
11/28/2024, 2:53 PMnanostring.
I would convert them to local modules which have the nf-core/modules format though (i.e. no underscores in name, and in their own folders with <http://main.nf|main.nf>, meta.yml etc)
That way you can move them to nf-core/modules more easily in future if there is a desire to use them outside of nanostringNicolás Alejandro Schcolnicov
11/28/2024, 2:56 PMArthur
11/28/2024, 2:58 PMMatthias Zepper
11/28/2024, 3:56 PM