Does anyone know why some of tests in gitactions a...
# pipeline-maintainers
l
Does anyone know why some of tests in gitactions are hanging there https://github.com/nf-core/taxprofiler/pull/554
m
these tests are specified in the branch rules
👍 1
do you have access to the admin panel on this repo?
l
I am not sure if I have admin right
Unfortunately I don’t have admin right
m
I'd say too much tests are required and we can probably trim that done
I can do it
❤️ 1
l
@James Fellows Yates 👆
m
this is what we require in #sarek
Firefox_Screenshot_2024-11-28T14-42-27.509Z.png
j
Ahh that's the old tests
jfk
m
List is too long for your pipeline:
I couldn't capture all
j
Bit @Maxime Garcia that means you don't check anything rihgt?
just linkiting?
(or rather, you can merge with entirely broken tests, except if there is a linting issue)
m
nope, because one of our actions in sarek thanks to @Adam Talbot check that no tests are failing
j
oooh
m
oh but it's not required facepalm
a
Yeah Github requires you to explicitly name ever test that is required
m
ok, I need to spend more time on this
a
there's no option for "all tests that were triggered pass"
m
except for the confirm-pass test
a
Yep, a manual version I wrote. It's a little crude, I'd much prefer a native solution
m
true that
j
ok well in the meantime @Lili Andersson-Li
I've changed the required tests to the latest test names
for
-profile test
it's for all three conda/docker/singluiarity
then for all the others it's just docker, but on both latest and 24.10
So that should cover evertyhing
And you now have an unblocked PR for merging 😄
❤️ 1