Hi! Is someone still using the `workflowCitation()...
# pipeline-maintainers
j
Hi! Is someone still using the
workflowCitation()
function in their pipeline? We have remove it from the template and replaced it by adding the DOI with the nf-schema plugin (see here), so we would have to remove this function from the
utils_nfcore_pipeline
subworkflow Please shout if you don't want to not do this change and continue using the function!
ping @James Fellows Yates?
j
More and more people are using it...
😁 1
j
PR here
j
Afaik
j
it was in the template before but we removed it with the last version
j
Eek ok that's worrying, I'll need to check then if the multiQC text is working or not
But I'm looking after Teo today and tomorrow unfortunately
Oh wait
So the variable itself is still there just in nextflow.config?
j
we add the DOI, and we specify it in the nextflow.config
but we don't add the same text as before with the function
j
Ah waaaaaiit
j
let's keep the function in the subworkflow for now? for those who want to use it 🤔
j
No I think I pull directly from manifest.doi
I don't think the MultiQC text ever used that function...
Methods description thing...
It's not referenced there is it? On my phone but I don't see anything myself
j
not with the multiQC 🙂 it was used with nf-validation before
j
Ok I don't think I ever touched that so you're good from my side
👏🏻 1
m
I thought you were talking about the citations from the tools used
So disappointed
😂 1
j
I added a point to the maintainers meeting agenda to doublecheck, thanks!
🙏 1
f
For the tools used I made an attempt at writing the methods description automatically based on ch_versions and a yaml with citations. It's not super refined, but if you're interested maybe something similar could be implemented in nf-core? @Maxime Garcia
👀 2
m
how do you generate
assets/software_references.yml
?
f
Manually 😬 It would be nice if it would be possible to generate
CITATIONS.md
from the yaml, then you only have to write the references once.
m
Agreeing with you
I'd say we'd just need to have one, and have a minimal software_references/citations with nextflow/docker/singularity/conda/nf-core..., and the rest should be auto build based on the modules meta.yml
f
Even cooler
m
I think that's one of the things @Alex Peltzer would hope to be done for #regulatory if I'm not mistaken
👍 1
👍🏻 1
a
Yeah we're finding these type of things nowadays and try to tackle them one by one once decided if it adds something
party this 1
👏🏻 1
j
Yeah we use the function in #mhcquant and #epitopeprediction .. but in favor of replacing it as suggested ✌🏼
j
Agreed in maintainers meeting to nuke it! So we told @Júlia Mir to goahead 🙂
👍 1