Conflict between `nf-core lint` and `pre-commit`… ...
# linting
c
Conflict between
nf-core lint
and `pre-commit`… I have a parameter that takes a numerical value between 0 and 1. Its default is 10⁻⁵. If the value is not identical in
.nextflow.config
and
nextflow_schema.json
, I get an
nf-core lint
error. If I represent it as
1e-5
or
0.00001
, then it is changed to
1e-05
by
nf-core lint
in
nextflow_schema.json
and I get an error. If I change it to ``1e-05`` in both files, I get a
pre-commit
error as
prettier
changes the values in the schema file to be
1e-5
. How can I solve that problem?
p
Ooh, that's a new one!
Need to ignore something. Either the lint test or prettier.
I'm not sure if prettier can ignore a chunk of json file? 🤔 Probably not as no comments in JSON
j
Not a new one, I think we had it in #C02K5GX2W93 a while ago... @Jasmin Frangenberg @Anan Ibrahim do you remember how we solved it?
👍🏻 1
j
I cannot find the PR that solved it (and neither the thread where we discussed it). I remember that you James solved it, but even in the "blame" view on Github I cannot find the change. This is our file, which works with notation like 1E-9 🤷 Maybe you can find a hint there @Charles Plessy?
j
I think it was @mashehu was involved... Unless it was something in tools or something?
🤔 1
j
True... But in tools would have solved it for everyone, no? 🤔 Hmm
j
I don't remember exactly is the problem 😬
m
Might the problem be the non-capital "e" in the number notation?
facepalm 1
c
Thanks everybody, our
dev
branch now passes both tests with
1E-05
in
nextflow.config
and
0.00001
/
number
in
nextflow_schema.json
.
Now, time for dinner 🍽️
p
How on earth did you figure that one out @mashehu ? 😂
m
Looked at the file @Jasmin Frangenberg linked and it was there 😄
🙌🏻 1
👍 1
j
E
😆 1