This message was deleted.
# helpdesks
steep-balloon-41261
01/26/2023, 2:22 PMThis message was deleted.
p
polite-kilobyte-67570
01/26/2023, 2:36 PMhuh, that sounds like a bug!
useTokentldschatMessageFormatterpolite-kilobyte-67570
01/26/2023, 2:39 PM• which version of components are you using?
• does the error change between version 0.2.1 and 0.2.3?
• what bundler/builder are you using?
b
brief-refrigerator-69901
01/26/2023, 2:43 PMI'm using components-react:
0.2.312p
polite-kilobyte-67570
01/26/2023, 2:49 PMthanks, are you using a nodejs version > 17.5 by chance?
b
brief-refrigerator-69901
01/26/2023, 2:52 PMyeah,
v19brief-refrigerator-69901
01/26/2023, 3:02 PMfrom what I see.. its being used here: https://github.com/livekit/components-js/blob/0e02fcab0e4247f70ce318837403fa465a89d80a/packages/core/src/helper/urlRegex.ts
brief-refrigerator-69901
01/26/2023, 3:03 PMThis said, you are right, it is as soon as I use any of the components to create a room.. such as:
Copy code
import {
useToken,
LiveKitRoom,
VideoConference,
} from "@livekit/components-react";useTokenp
polite-kilobyte-67570
01/26/2023, 3:04 PMyup, this is connected to import assertions being required in nodejs v17.5 and above for JSON imports
polite-kilobyte-67570
01/26/2023, 3:05 PMI guess nodejs simply complains because the import exists in the file.
b
brief-refrigerator-69901
01/26/2023, 3:06 PMisn't the fix to only do something like:
Copy code
import tlds from 'tlds' assert {type: 'json'};p
polite-kilobyte-67570
01/26/2023, 3:07 PMyeah, that’s the fix, I’m just trying to figure out if this breaks things with older node versions
b
brief-refrigerator-69901
01/26/2023, 3:08 PMGotcha 🙂
brief-refrigerator-69901
01/26/2023, 3:11 PM Copy code
Node JS : v17.1.0, v16.14.0
Add support for import assertions.brief-refrigerator-69901
01/26/2023, 3:12 PMLiveKit is planning on supporting up to which older version?
p
polite-kilobyte-67570
01/26/2023, 3:13 PMit’s not set in stone, for components specifically we won’t strive to support versions that have reached EOL already, but v14 is still in maintenance mode, so if nothing speaks against that, that would be the earliest version we would strive to support
polite-kilobyte-67570
01/26/2023, 3:14 PMin some local tests things seem to work fine with v14 too though
🙌 1
b
brief-refrigerator-69901
01/26/2023, 3:15 PMWell, that's great news. Maybe they've backported support or its simply being ignored in earlier version since its only adding more context 🤷♂️
p
polite-kilobyte-67570
01/26/2023, 3:35 PMyeah not sure what, but opted to just not use JSON imports - just to be safe 😄
here’s the fix, we’ll have a high release cadence during our preview phase anyways so I’ll rollout a release in a bit!
🙌 1
b
brief-refrigerator-69901
01/26/2023, 3:36 PMYeah I was following the PR 😉 Great work @polite-kilobyte-67570! And thanks a lot for the quick fix! Much appreciated.
❤️ 1
➕ 1
brief-refrigerator-69901
01/26/2023, 3:36 PMIll keep an eye out for the new release, and I can let you know if everything works 🙂
p
polite-kilobyte-67570
01/26/2023, 3:36 PMgreat, thank you!
❤️ 1
b
brief-refrigerator-69901
01/26/2023, 4:05 PMThis fixed it @polite-kilobyte-67570!
p
polite-kilobyte-67570
01/26/2023, 4:06 PMnice!
b
brief-refrigerator-69901
01/26/2023, 4:17 PMThanks.
4 Views