https://livekit.io logo
Join Slack
Powered by
# helpdesk
  • w
    yep 1 moment
  • w
    deploying
  • w
    multi-node is enabled btw
  • w
    still seeing
    Copy code
    export interface ConnectionInfo {
  host: string;
  port: number;
  secure?: boolean;
}
  • d
    cool, lemme know how it works.. I spent most of last night tracking down issues with multi-node.. turns out my integration test had a bug.. and it wasn't testing the actual thing
    🙌 2
  • w
    I don't see anything about audio/video for that 
    join
    method
  • d
    it should be the last param
  • d
    ConnectOptions
  • w
    is it pushed to branch 
    main
    ?
  • w
    Copy code
    join(info: ConnectionInfo, token: string): Promise<JoinResponse>;
  • w
    that's the sig I see, line 23 
    src/api/RTCClient.ts
  • d
  • w
    ah
  • w
    CreateLocalTracksOptions
  • w
    here are the connect options
  • w
    Copy code
    export interface ConnectOptions {
  // name of the room to join
  logLevel?: LogLevel;
}
  • w
    again no reference to audio/video
  • w
    I liked it the way it was before where all 
    join
    did was establish the connection but I could see how some users might expect that to also publish media
  • w
    but some users might only want to view
  • w
    maybe even a large % of users
  • w
    users, i.e. streamers
  • d
    yeah, the idea is really to have parity with twilio's sdk, since our APIs are compatible with theirs
  • d
    they have this behavior, so I was trying to match it to avoid confusion when someone's already used to Twilio's sdk..
  • d
    you have some good points tho.. I'll think through it
  • w
    I see. It's an odd assumption to make though (that everyone wants to publish video)
  • w
    our audiences will primarily be streaming, and only a few publishing
  • d
    perhaps it should default to not publishing.. but still support the flags
  • w
    +1
  • w
    so default the flags to false
  • w
    testing with latest changes. Before I start, do you want me to clean up my tracks when hanging up? Or do you want to test the case of many tracks pushed from the same user?
1...567...91Latest