https://livekit.io logo
Join Slack
Powered by
# helpdesk
  • d
    give it a shot and lmk. I'm certain there could still be race conditions here and there.. but this should have solved a good number of them
  • c
    the version before this was already a lot more stable for me
  • d
    will need to add more integration testing to simulate these use cases.
  • c
    just pulled
  • d
    👍
  • d
    I'm surprised you are still up! I'm gonna check out for the night, 'nite 💤
  • c
    haha this is my dev time 🙂, thanks again i’ll let you know how it looks in the AM
  • w
    testing new changes now
  • w
    still more of em, I'll post panic dumps in a minute
  • w
    Copy code
    {"level":"debug","ts":1611762398.926243,"caller":"rtc/participant.go:486","msg":"updating participant state","state":"DISCONNECTED","participant":"PA_xbZp5pj7e9CgNApXn9my27"}
{"level":"debug","ts":1611762398.9546442,"caller":"rtc/room.go:63","msg":"participant state changed","state":"DISCONNECTED","participant":"PA_xbZp5pj7e9CgNApXn9my27","oldState":"ACTIVE"}
panic: send on closed channel

goroutine 1519 [running]:
<http://github.com/livekit/livekit-server/pkg/routing.(*MessageChannel).WriteMessage(0xc0010e7300|github.com/livekit/livekit-server/pkg/routing.(*MessageChannel).WriteMessage(0xc0010e7300>, 0xe78680, 0xc00117c400, 0x4106e5, 0xc001077ca0)
	/workspace/pkg/routing/messagechannel.go:30 +0x74
<http://github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).SendParticipantUpdate(0xc000cd6400|github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).SendParticipantUpdate(0xc000cd6400>, 0xc0019d0ac0, 0x1, 0x1, 0x1, 0x1)
	/workspace/pkg/rtc/participant.go:380 +0xda
<http://github.com/livekit/livekit-server/pkg/rtc.(*Room).broadcastParticipantState|github.com/livekit/livekit-server/pkg/rtc.(*Room).broadcastParticipantState>(0xc0001be480, 0xe93dc0, 0xc000d2d400)
	/workspace/pkg/rtc/room.go:202 +0x24d
<http://github.com/livekit/livekit-server/pkg/rtc.(*Room).onTrackAdded|github.com/livekit/livekit-server/pkg/rtc.(*Room).onTrackAdded>(0xc0001be480, 0xe93dc0, 0xc000d2d400, 0xe8e6e0, 0xc00117a240)
	/workspace/pkg/rtc/room.go:157 +0x6d
<http://github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).handleTrackPublished(0xc000d2d400|github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).handleTrackPublished(0xc000d2d400>, 0xe8e6e0, 0xc00117a240)
	/workspace/pkg/rtc/participant.go:561 +0x17e
<http://github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).onMediaTrack|github.com/livekit/livekit-server/pkg/rtc.(*ParticipantImpl).onMediaTrack>(0xc000d2d400, 0xc0011ea120, 0xc00187df80)
	/workspace/pkg/rtc/participant.go:509 +0x274
created by <http://github.com/pion/webrtc/v3.(*PeerConnection).onTrack|github.com/pion/webrtc/v3.(*PeerConnection).onTrack>
	/go/pkg/mod/github.com/pion/webrtc/v3@v3.0.4/peerconnection.go:442 +0x10f
{"level":"info","ts":1611762401.688513,"caller":"server/main.go:145","msg":"configured key provider","num_keys":1}
{"level":"info","ts":1611762401.8139203,"caller":"server/main.go:192","msg":"using single-node routing"}
{"level":"info","ts":1611762401.8154325,"caller":"service/server.go:100","msg":"starting LiveKit server","address":":7880","nodeId":"ND_0000000000000000"}
  • w
    let me reproduce locally because those stack traces are more detailed
  • d
    this is good. thanks, will track them down
  • w
    sounds good, tyvm @dry-elephant-14928
  • w
    do you have a day job?
  • d
    yeah for now. this is gonna be my main thing.
  • w
    sweet
  • c
    @wonderful-manchester-12533 you have a day job too lol
    🤣 3
  • w
    @clever-kite-90169 yes lol but I take days off often because I dislike it + unlimited pto === win
  • d
    @wonderful-manchester-12533 give multi-node a try, it should work. better now
  • w
    cool one moment
  • d
    this. current panic seems odd.. should have a very low chance of happening.. how many participants are you running with? and what's the connection pattern?
  • w
    2
  • w
    What do you mean by connection pattern?
  • d
    are they connecting at the same time?
  • d
    or how is it disconnecting? just trying to get a repro locally
  • w
    The client gets an 
    onclose
    event
  • w
    get both participants to publish then unpublish, publish, unpublish over and over and it'll eventually close the sockets
  • w
    It's not very deterministic right now
  • d
    oh, so you are not trying to disconnect.. but it's the publish/unpublish sequence that kills it?
  • w
    yes
12345...91Latest