https://livekit.io logo
Join Slack
Powered by
# helpdesk
  • w

    wonderful-manchester-12533

    02/09/2021, 12:47 AM
    right now this is what we're doing:
    Copy code
    const at = new AccessToken(API_KEY, API_SECRET, {
                identity: participantName,
            });
  • d

    dry-elephant-14928

    02/09/2021, 12:47 AM
    access token is internal to LK.. so not sure if it's a good idea to expose the claims in there to clients
  • w

    wonderful-manchester-12533

    02/09/2021, 12:47 AM
    well I feel like lk should be able to accept a token that has extra metadata that can be forwarded to the clients
  • d

    dry-elephant-14928

    02/09/2021, 12:48 AM
    what type of metadata?
  • w

    wonderful-manchester-12533

    02/09/2021, 12:48 AM
    could use that to easily add custom features on top of the livekit layer like roles without having to modify livekit
  • w

    wonderful-manchester-12533

    02/09/2021, 12:48 AM
    first is a
    seat_id
    we want to add
  • d

    dry-elephant-14928

    02/09/2021, 12:48 AM
    I see.. so this is something you are comfortable with all users seeing
  • w

    wonderful-manchester-12533

    02/09/2021, 12:48 AM
    and if its in the token, we don't need to worry about propagating or storing that data when the participants are rendering a new track
  • w

    wonderful-manchester-12533

    02/09/2021, 12:48 AM
    yes exactly
  • w

    wonderful-manchester-12533

    02/09/2021, 12:49 AM
    we can also trust it when its in the token because we can always validate the sig
  • d

    dry-elephant-14928

    02/09/2021, 12:49 AM
    that makes sense.. that's a good idea
  • w

    wonderful-manchester-12533

    02/09/2021, 12:49 AM
    sweet, do you want me to file anything on github?
  • d

    dry-elephant-14928

    02/09/2021, 12:49 AM
    just custom participant data
  • w

    wonderful-manchester-12533

    02/09/2021, 12:49 AM
    right
  • d

    dry-elephant-14928

    02/09/2021, 12:50 AM
    you can file an issue and note that it's a feature
  • w

    wonderful-manchester-12533

    02/09/2021, 12:50 AM
    got it, will do
  • c

    clever-kite-90169

    02/09/2021, 12:51 AM
    Added some info on the Websocket connect bug, i'd say it's top 2 on our priority list right now
  • s

    steep-balloon-41261

    02/09/2021, 12:51 AM
    This message was deleted.
    c
    d
    • 3
    • 4
  • s

    steep-balloon-41261

    02/10/2021, 6:25 PM
    This message was deleted.
    👋 3
    m
    • 2
    • 1
  • j

    jolly-crowd-23503

    02/10/2021, 6:30 PM
    my username is edwardysun on github
  • d

    dry-elephant-14928

    02/10/2021, 6:31 PM
    good to meet you Edward! definitely. will add you shortly
  • j

    jolly-crowd-23503

    02/10/2021, 6:58 PM
    thanks david!
  • w

    wonderful-manchester-12533

    02/10/2021, 10:25 PM
    @dry-elephant-14928 is there any way that lk can clear out everything related to a user the minute their socket disconnects instead of 5-10 seconds after?
  • d

    dry-elephant-14928

    02/10/2021, 10:55 PM
    so for disconnections we rely on the peerconnection, not websocket. currently the peerconnection goes from connected to disconnected after 5s
  • d

    dry-elephant-14928

    02/10/2021, 10:55 PM
    that might be configurable..
  • d

    dry-elephant-14928

    02/10/2021, 10:55 PM
    what is the need to clear the user out earlier?
  • w

    wonderful-manchester-12533

    02/10/2021, 10:58 PM
    if a user refreshes their screen, there's no guarantee for us that we will call
    unpublishTracks
    in time before the browser loads again
  • w

    wonderful-manchester-12533

    02/10/2021, 10:58 PM
    I'm trying to see if I can hook into
    beforeunload
    in the browser and how consistent that is for disconnecting
  • d

    dry-elephant-14928

    02/10/2021, 11:00 PM
    LK does detect reconnects.. and I'm sure we can make it so that it sends unpublished when that reconnect happens..
  • w

    wonderful-manchester-12533

    02/10/2021, 11:01 PM
    gotcha
1...151617...91Latest