Hi All, Seems there is a bug in Saved Charts. Whi...
# general
a
Hi All, Seems there is a bug in Saved Charts. While opening a particular saved chart going for infinite re-rendering.
Copy code
Error ID: ceee435996c44633aa080adce5760ecb
Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
Step to Reproduce. 1. Go to Home Page. 2. Go to Saved Charts. 3. Search below given chart. “How do payment methods vary across different amount ranges?” I have attached a screenshot of the console.
1
p
👋 Thanks for your message - someone from the Lightdash support team will get back to you asap. Feel free to add any additional context to the thread here in the meantime (screenshots, app version if you're self-hosting etc.).
j
Hi Ajit, thanks for the report. I don’t see anything wrong with that chart. Are you running on seflhosting ? what is your lightdash version ? Does this happen on other charts too ? It seems this rendering issue is triggered from the
suboptimal
state, which is a special component we show when something hasn’t loaded, or there is an error. Do you know what the underlying error is ?
could you see if you get any other issues on the backend logs, or in the
network
tab in the JS console ?
j
a
Hi Javi, I am running at my localhost. And this is happening with the mentioned above given particular chart for Jaffle shop. I just setup Lightdash locally to contribute through Docker environment. Attached screen recording for reference.
I would like to work on this bug. I am going through the code base to get the root cause for this.
j
This was likely introduced in my last commit and seems to happen when the chart is pivoting /grouping.
👍 1
There might be a problem with a hook dependency that is constantly changing
We are going to start investigating but let us know if you find the issue first. There is also a chance we will revert the entire commit.
a
Sure Jose, Will let you know if I found the issue.
j
Fix as been merged
👍 1
a
Yes this is fixed now.
🥳 1