This message was deleted.
# infisical-feedback
s
This message was deleted.
r
Import and export is buggy It seems like the “drag and drop an .env, .json or .yml file” is completely broken. I manually added everything for one environment, used the CLI to export each format, tried to update to QA and import back in. Sometimes it finds a single line, sometimes it seems to do nothing. None of the formats appeared to work
When it did work in DEV env, it ignored the setting and made everything UPPERCASE. We tend to use longer settings keys, so UPPERCASE is not easy for us to read (e.g. PhelixApiBaseUrl) this is not a deal breaker, so I went back and tried to switch to upper case when i noticed the next dealbreaker:
Secret names are case sensitive I believe that secret names should match regardless of case. In other words HOST and host should be the same key. I’m pretty sure the env vars are not looking at case, and i’m not sure what would happen when I have two settings with the same name in different cases. I think this is too much of a “foot-gun” for someone on my team to accidentally not realize they’ve already added a key
Import from CLI also seems buggy I got a number of errors when importing from CLI using this format
infisical secrets set -l trace --env=qa --domain=https://infisical.eikongroup.io LOG:LOGLEVEL=Debug
Usually the error was something like
Hmm, we ran into an error: CallCreateSecretsV3: Unsuccessful response. Please make sure your secret path, workspace and environment name are all correct [response={}]
but no error on the server logs and no way for me to find out what went wrong. This seemed to happen the most with an empty environment
after all this, I realized the reason that I was exporting in the first place us because the UI isn’t working the way I would personally want it to, which is to compare secrets across all environments. The way I do this right now is export from AWS Secrets manager to JSON using the CLI, and then use Beyond Compare to compare each JSON… dev to qa, qa to stg, stg to live, etc
This is what attracted me to Infisical in the first place. This is what our project page looks like for a new app we’re working on
I added Dev by hand and now I want to update QA. but when I go into QA, I have to manually add everything again
the dashboard then is only useful to tell me if I’m missing a setting, but not what it is, and I basically need to have two windows open side by side and scan them by eye. This is worse than my beyond compare workflow IMO
I absolutely LOVE the feature of setting an expansion like ${ENV} and reusing that in my settings because may settings only vary by the ENV.. for example SSO Auth URI
but the main project page actually makes it really hard to see which settings are matching across all envs because I have to click the eye next to each setting to see if the values are the same. IMO this is unnecessary and i’d get rid of it, or move it to the top of the page and toggle all the settings on and off at once
I’d love the ability to see which settings are the same across all environments, and which are different. I’d love the ability to have a little button (->) to copy a value from one env to another from the main project page
Secrets Scanning The other feature I was hyped for was the secrets scanning. This works really well, and having it as a hook is a great feature. But I also want to add it to my gitlab pipeline to reject builds that include new secrets. I spent a lot of time figuring out how to pass git log options to not scan the pipeline branches and just scan things in origin/* Once I got that working, I used the baseline feature, which unfortunately (stupidly) i just doubled my secrets count by checking this file in… I then decided the .infsicalignore file would be a better approach for me. I created a little hacky command to build this file
Copy code
infisical scan -v --log-opts="HEAD" | grep Fingerprint: | sed 's/Fingerprint: //' > .infisicalignore
and then made it and checked it in… only to find that Gitlab only checks out with a depth of 20 by default. This means that the .infisicalignore file I generate on my computer will not work on Gitlab because the file contains the commit number where the secret was first found. This is different when you check out to a different depth. My recommendation here would be to change the format of this file so the first part of the thumbprint is actually a hash of the secret
edf22805a71b475049d148a81194be50360d08f0:alula.orders.api/Properties/launchSettings.json:generic-api-key:15
changes to
HashOfSecret:alula.orders.api/Properties/launchSettings.json:generic-api-key:15
the reason is that if I whitelist a secret its because it 1) doesn’t matter (i.e. pass or something dumb used as a local docker default) or 2) it was a legit secret and we made the user change that password / rotate the key and now it’s not a risk anymore. It shouldn’t error again, unless the secret itself changes
anyway lmk if you want more information / details. I realize this is just my opinion but these are the things that would make it really perfect for our use case
m
Hey Ryan! Thank you so much for the detailed feedback. We really appreciate you taking the time to write this out. I’m looking forward to having you use Infisical again and get these issues looked into. You mentioned you were having trouble with the drag and drop feature. What kind of files were you uploading? Were these .env files, yamls, etc. Also can you give a range of the number of secrets you were uploading? This is to understand if there was a performance edge case we missed for the upload As for auto capitalization, we have a toggle in the project settings which will disable the auto capitalization for imports. In terms of case sensitivity, perhaps having a toggle in the project settings to disable this could be helpful for your team?
r
drag and drop feature
I was using infisical to generate the files using the export feature. I tried to export all the formats and tried each of them. I can sanitize one of my files and provide it to you if that would help? Sometimes it added a single entry. I was expecting that I could export Dev, find and replace “dev” to “qa” and update a few settings, then import
auto capitalization
Found that and switched it off, but I think the CLI
infisical secrets set
command ignores it. After I couldn’t get the file import to work, I used my exported file to craft a new CLI command to set all the secrets that way. It automatically converted them all to UPPERCASE
case sensitivity, perhaps having a toggle
would love that
also just wanted to reiterate that I love the idea of this project and i’m super excited about it
v
Hi Ryan! First of all, thank you so much for your feedback! This has been one of the most thorough and most useful reviews we have ever received, and I found it extremely helpful. I think we need to spend quite some effort to seal all the existing features and make sure the experience is completely bugless. Some of these features that you have described are already in the pipeline. In fact, we are soon adding the ability to quickly copy secrets in between environments, the ability to replicate environments, etc. I have also noted down all your other feedback and we will aim to fix it in the next 2 weeks. I know it might be too much to ask, but is there any chance I could grab 15 minutes of your time by the end of these two weeks to show you all the progress we have made? I would really love to have an opportunity to prove to you that we value this feedback a lot, and are obsessed to make the best developer experience possible. If you’re able to find 15 minutes in early August, then please tell when works best for you, and I will make any time work! Again, I really appreciate your feedback, and I’m hoping that you would give us another chance in future, once Infisical becomes significantly better 🙂
y
@Ryan Just adding my point of view here. I believe you would use Infisical 🙂 We started a POC a week ago and @Vlad (Infisical) and the team are super responsive at addressing even the tiniest issues. Nobody is paying me 😂 We just really love the product and the problem it solves for us. And personally I'm super passionate about products that are sensitive about developer experience, and Infisical is definitely like that.
❤️ 5
v
Thank you so much Yaron! Appreciate it a lot! pepelove
a
Best review i have seen in my whole life. Really appreciate your patience.
a
Best review I have ever seen also Thanks for taking your time to point out all these, really appreciate too ☺️
r
Yes absolutely. All our changes are sitting on a branch waiting for another chance 🙂 Those changes were pretty minor too, which is a great feeling - not having to rewrite a ton of stuff, and easy for everyone to understand what’s happening
🦠 5
I figured out the secrets importing issue. It seems to error out when my keys have “:” in the name. This is a very common convention in the .aspnet world. There is an alternative, double underscore, and when I convert my key names the import works.
👀 1
want me to create an issue on Github?
v
Oh, huh, that is very interesting! Yes, please, the issue would be helpful. We will fix this We are actually releasing some changes/improvements to the dashboard already today. So stay tuned!
🙌 1
cheers
v
Perfect! Thank you Ryan!
Hey @Ryan! Just wanted to let you know that we have fixed the error with colons when parsing .env files. I remember you’re self-hosting, so you can update to the latest version, and it should work. Could you please let me know if it works as expected? Otherwise, this will be released in Infisical Cloud tomorrow morning
r
@Vlad (Infisical) pulled and its working perfectly. I also noticed that v.0.10 no longer changes the case of the secrets name, amazing 👏 thanks guys
v
Of course! I’ll keep you updated about the other points of feedback in this thread as we implement those! 🙂