https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • m
    well, I should say, we try to do the right thing
  • b
    @User Not boosting the links and can replicate the issue with a barebones setup: https://putyourlightson.com/test1
  • b
    I think I've tracked down the issue, will create a bug report in github.
  • b
  • b
    @User Probably wise to require a specific version of htmx at this early stage, e.g. https://unpkg.com/htmx.org@0.0.7
  • m
    @User looking at the issue, why would clicking on a link popstate? Is it due to a back button click?
  • b
    Because the link has 
    href="#xyz"
    which updates the history.
  • b
    Through digging into the code I better understand the reasoning for restoring history from local storage.
  • m
    so it's the back button that triggers onpopstate though, right?
  • m
    I think I see the problem
  • m
    I need to ensure that the pop event is from htmx, not a local nav
  • b
    No, clicking the link does, because it updates the URL.
  • m
    thats's a push state, no?
  • m
    ah, looks like both
  • m
  • m
    a little confusing
  • b
    Indeed
  • m
    i had no idea that clicking on a local anchor tag did that
  • m
    looking back at intercooler, I do check to see if the history event was created by htmx
  • m
    so that appears to be the fix
  • b
    Do you agree with the premise that local cache should only be used when the pop event is from htmx? I confused myself a bit with trying to figure out what was going on and want to make sure I haven't just jumped to an inaccurate conclusion...
  • m
    Yes.
  • b
    Ok great
  • m
    Copy code
    javascript
 function handleHistoryNavigation(event) {
      var data = event.state;
      if (data && data['ic-id']) {
  • m
    that's the relevant code from intercooler
  • m
    we only do history processing if the history event was created by intercooler
  • b
    So if the prefix is 
    ic-
    ?
  • b
    Oh, only if 
    data['ic-id']
    exists, I see.
  • m
  • m
    I think that might work
1...678...1146Latest