https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • g

    gorgeous-ghost-95789

    09/26/2020, 2:26 AM
    Yup. Sorry I missed your notes before. Everything is open source right now github.com/benpate/ghost — but it’s not really demo-able. I’ll share more with it makes sense to outside eyes.
  • g

    gorgeous-ghost-95789

    09/26/2020, 2:27 AM
    It’s funny, everyone needs their own CMS.. It’s almost like none of the ones out there are any good...
  • l

    lively-beach-14291

    09/26/2020, 3:51 AM
    benpate: for a CMS to be useful it needs to be tied to relevant workflows
  • g

    gorgeous-airport-54386

    09/26/2020, 9:19 AM
    The acronym CMS is the combination of the three most generic words in software terminology, so it's no wonder that there are lots of them
  • g

    gorgeous-ghost-95789

    09/27/2020, 12:56 AM
    both excellent points. 🙂
  • m

    mysterious-toddler-20573

    09/27/2020, 1:41 AM
    ThingHolderDoer
  • m

    most-jelly-15242

    09/27/2020, 9:27 PM
    @User Can you take a look at this this pen https://codepen.io/jreviews/pen/rNebONr?editors=1011 I am not really sure how to write a test for this, but when there is a chain of events and the original HX-Active-Element is no longer present within the response, the execution errors in
    doSwap
    , like 1892:
    Copy code
    js
    newActiveElt.focus();
    Would it be possible to add a check to make sure newActiveElt is not null? Everything else works fine.
  • m

    mysterious-toddler-20573

    09/27/2020, 9:44 PM
    absolutely
  • m

    mysterious-toddler-20573

    09/27/2020, 9:44 PM
    Do you want to do so locally and then submit a pull request?
  • m

    mysterious-toddler-20573

    09/27/2020, 9:46 PM
    looking at teh code, this should be in there anyway
  • m

    mysterious-toddler-20573

    09/27/2020, 9:46 PM
    no guarantee that the selected element is going to be around
  • m

    mysterious-toddler-20573

    09/27/2020, 9:46 PM
    looking to see if I can write a test
  • m

    mysterious-toddler-20573

    09/27/2020, 9:53 PM
    fixed in dev: https://github.com/bigskysoftware/htmx/commit/09712012c64a12c2e4f381a8732c24577c862ddb
  • m

    mysterious-toddler-20573

    09/27/2020, 9:53 PM
    w/ a regression test, sorry about that
  • m

    most-jelly-15242

    09/27/2020, 10:18 PM
    Well, that was a lot easier to reproduce than my pen. Thanks!
  • m

    mysterious-toddler-20573

    09/29/2020, 12:49 AM
    file upload first pass: https://github.com/bigskysoftware/htmx/commit/7b9e75196040203c7eab1ecb7c47858f89b68b91
  • m

    mysterious-toddler-20573

    09/29/2020, 12:49 AM
    second set of eyes very welcome
  • m

    mysterious-toddler-20573

    09/29/2020, 12:49 AM
    hard to test
  • m

    most-jelly-15242

    09/29/2020, 1:51 PM
    @User I started checking this and found an issue on line 1570:
    Copy code
    formData.append(name, v);
    v
    is undefined there. I think it should be
    value
    ? This is in the else statement. I'll try to continue later today.
  • m

    mysterious-toddler-20573

    09/29/2020, 1:59 PM
    Thank you! I want to add tests for everything except the file upload.
  • m

    most-jelly-15242

    09/29/2020, 3:11 PM
    Is this an issue? For post requests even when set to
    multipart/form-data
    it uses a different content-type
  • m

    most-jelly-15242

    09/29/2020, 4:16 PM
    Managed to get the uploads working, but only after commenting this line:
    Copy code
    js
    headers["Content-Type"] = "multipart/form-data";
  • m

    mysterious-toddler-20573

    09/29/2020, 4:17 PM
    awesome, thank you alejandros
  • m

    mysterious-toddler-20573

    09/29/2020, 4:17 PM
    yes, I need to fix both those issues
  • m

    most-jelly-15242

    09/29/2020, 4:17 PM
    Sorry, wrong line. This one: headers["Content-Type"] = "application/x-www-form-urlencoded; charset=UTF-8";
  • m

    most-jelly-15242

    09/29/2020, 4:17 PM
    If I add the multipart header it doesn't work.
  • m

    mysterious-toddler-20573

    09/29/2020, 4:19 PM
    right
  • m

    mysterious-toddler-20573

    09/29/2020, 4:19 PM
    I am adding tests for all this now!
  • m

    mysterious-toddler-20573

    09/29/2020, 4:46 PM
    @User updated to fix the issues you pointed out, w/ a test
  • m

    mysterious-toddler-20573

    09/29/2020, 4:46 PM
    https://github.com/bigskysoftware/htmx/tree/feature_file_upload
1...414243...1146Latest