https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • m

    mysterious-toddler-20573

    09/18/2020, 3:08 PM
    :p
  • m

    mysterious-toddler-20573

    09/18/2020, 3:08 PM
    can I see your extension code
  • m

    mysterious-toddler-20573

    09/18/2020, 3:08 PM
    ?
  • m

    mysterious-toddler-20573

    09/18/2020, 3:08 PM
    lol
  • m

    most-jelly-15242

    09/18/2020, 3:08 PM
    I did ask if you wanted me to test it
  • m

    mysterious-toddler-20573

    09/18/2020, 3:09 PM
    but i wrote a test!
  • m

    mysterious-toddler-20573

    09/18/2020, 3:09 PM
    I told you people I needed coffee
  • m

    most-jelly-15242

    09/18/2020, 3:10 PM
    This is a simplified version of the onEvent method in the extension:
    Copy code
    js
    onEvent: function (name, evt) {
        if (name.split(":")[0] === "namespace") {
            const eventName = name.split(":").slice(1).join(":");
            htmx.trigger(document, eventName, {})
          }
    }
  • m

    mysterious-toddler-20573

    09/18/2020, 3:10 PM
    so my change definitely fixed a double event dispatch, when the kebab name matches the camel case name
  • m

    mysterious-toddler-20573

    09/18/2020, 3:11 PM
    but it shouldn't have changed the original dispatch of the event
  • m

    mysterious-toddler-20573

    09/18/2020, 3:11 PM
    stares at code
  • m

    mysterious-toddler-20573

    09/18/2020, 3:12 PM
    make an open source project they said
  • m

    mysterious-toddler-20573

    09/18/2020, 3:12 PM
    it'll be fun, they said
  • m

    most-jelly-15242

    09/18/2020, 3:12 PM
    The problem is that onEvent seems to be ignoring my
    namespace:refresh
    event.
  • m

    mysterious-toddler-20573

    09/18/2020, 3:13 PM
    Copy code
    js
                if (eventResult && kebabName !== eventName) {
                    var kebabedEvent = makeEvent(kebabName, event.detail);
                    eventResult = eventResult && elt.dispatchEvent(kebabedEvent)
                }
                withExtensions(elt, function (extension) {
                    eventResult = eventResult && (extension.onEvent(eventName, event) !== false)
                });
  • m

    mysterious-toddler-20573

    09/18/2020, 3:13 PM
    all I added was that guard to not dispatch the second event if the names are the same
  • m

    mysterious-toddler-20573

    09/18/2020, 3:14 PM
    the withExtensions should run regardless, with the original event name
  • m

    mysterious-toddler-20573

    09/18/2020, 3:14 PM
    but I do need coffee
  • l

    lively-beach-14291

    09/18/2020, 3:14 PM
    @mysterious-toddler-20573 Regarding OSS projects, I've had people go out of their way to be hostile to me on airplanes...
  • m

    mysterious-toddler-20573

    09/18/2020, 3:15 PM
    lol
  • m

    most-jelly-15242

    09/18/2020, 3:16 PM
    @mysterious-toddler-20573 extension is running, but not seeing any events other than
    htmx
    namespaced events. This is only with 0.1.1.
  • m

    mysterious-toddler-20573

    09/18/2020, 3:17 PM
    that's pretty spooky
  • m

    most-jelly-15242

    09/18/2020, 3:18 PM
    going to download 0.1.1 and load it locally to check
  • m

    mysterious-toddler-20573

    09/18/2020, 3:18 PM
    roger. Can you set a breakpoint at line 1142 ?
  • m

    mysterious-toddler-20573

    09/18/2020, 3:18 PM
    That should show you what's going on
  • m

    most-jelly-15242

    09/18/2020, 3:29 PM
    I add
    console.log(eventName)
    right after 1142. On 1.1.0, I can't see my custom event. But it does show up on 1.0.0. I will check a bit further down
  • m

    mysterious-toddler-20573

    09/18/2020, 3:29 PM
    @User I added two tests for your situation @User both are passing
  • m

    mysterious-toddler-20573

    09/18/2020, 3:30 PM
    the HX-Trigger header logic is the same in both
  • m

    mysterious-toddler-20573

    09/18/2020, 3:30 PM
    are there any other factors? hyperscript?
  • m

    most-jelly-15242

    09/18/2020, 3:31 PM
    no hyperscript
1...333435...1146Latest