https://htmx.org logo
Join Discord
Powered by
# htmx-general
  • m
    Actually, yes, it may be outerHTML. I had it set to innerHTML, but I am using IDs, so I think that's being ignored
  • m
    @mysterious-toddler-20573 you are right, it's the outerHTML that's causing the issue. I tested without the ID attribute and without OOB and the event is triggered.
  • m
    OK. I thought so. I don't think I ever got that quite right with intercooler either :/
  • m
    OOB is pretty cool 🙂
  • m
    I'll try to get a fix in soon. If you have time to put together a test case that would be extremely helpful
  • m
    A PR for a test case? I haven't looked at those yet, but I can try
  • m
    yes, that would be great
  • m
    the events tests are pretty straight forward and I can envision what one would look like, but it's always nice to have someone else write the test case
  • m
    done!
  • m
    awesome, thank you
  • b
  • m
    @User Yes, related. But do you have a test there for outerHTML swap? I didn't see it. The two tests I added are for outerHTML.
  • b
    Not specifically, no, but I agree with your findings so will be good to have it.
  • m
    Checking your PR, there's something I don't understand. In one of the failed request tests, is the request really failing? I don't see it . This one https://github.com/bigskysoftware/htmx/pull/166/commits/bfaedef4978b4a21b7207fade3b6911208dda34d#diff-ebdd1660cb9123ede8eca83e1c394237R157
  • b
    Open the console and try the various test cases here, the behaviour appears to depend on the nature of the swap. https://putyourlightson.dev/htmx.html
  • m
    Sorry, maybe I wasn't clear. How are you simulating the failed request in that test I linked to? It responds with a 200 status code.
  • b
    I didn't say that it failed...?
  • b
    Ah I see what you mean now @User, sorry for being slow! Here is where that event is triggered after a failed request: https://github.com/bigskysoftware/htmx/blob/v0.0.8/src/htmx.js#L1608
  • m
    The challenges of the written word 😉 The thing is that if you look at the code in the test (screenshot), even though it's for a 
    failed request
    , in the test itself, I don't see where you are simulating a failed request. Shouldn't it respond with something other than 200 status code.
  • m
    WebStorm loaded, DSA keyboard plugged in, Widescreen monitor with resolution set to OLD PERSON, listening to https://yewtu.be/watch?v=YZj5QsMl3x8
  • m
    Not making any promises, but I have written code in this configuration before
  • m
    spriggle me this...
  • m
  • m
    YOU'VE BEEN SPRAMBOOZLED BY... THE SPRIGGLER
  • m
    next release is gonna be 0.1
  • m
    @User once I get my head around your SSE stuff and merge it in we'll be close to a 1.0
  • m
  • m
    OK, that's all the fun I get to have today.
  • b
    🎉
  • m
    Thanks!
1...212223...1146Latest