This message was deleted.
# generals
Slackbot
06/09/2023, 4:43 PMThis message was deleted.
👀 1
e
Elijah Ben Izzy
06/09/2023, 4:54 PMSo yeah, I think I put that in just in case the API needed to settle, although I doubt it will change much at all. As in, we reserve the right to change the API, but it won’t be:
(1) in a way that is impossible to adapt to
(2) in a way that fundamentally alters what we’re trying to do
And, honestly, we’re unlikely to change it in a way that’s backwards incompatible. So, as long as you have a unit test on it (for new Hamilton versions), I’d feel comfortable subclassing it. You can always reach out to us if anything breaks, and the more people using this feature, the happier we’ll be to solidify it.
👍 1
Elijah Ben Izzy
06/09/2023, 4:56 PMWhen you do subclass it, there are three methods you’ll want to change:
1.
applicable_typessave_datanamet
Thibault Irissou
06/09/2023, 5:10 PMThanks @Elijah Ben Izzy! And super neat code btw, I’ve been loving it so far.
❤️ 1
e
Elijah Ben Izzy
06/09/2023, 5:11 PMAwesome! Thrilled to hear 🙂
s
Stefan Krawczyk
06/09/2023, 5:40 PM@Thibault Irissou there’s an item to straighten up some of the internal class naming, but we can CC you on the PR.
2 Views