Hey this may be a silly question but we've just st...
# how-do-i
l
Hey this may be a silly question but we've just started using the Merge-Queue, however have noticed that the PRs from the merge-queue no longer show-up in the release notes when creating a release via Github -- I'm guessing this is due to how the merge queue is merging the PRs (fast forward) is there a way to have these PRs still show up in the automatically generated release notes?
p
(If applicable) To help us more clearly understand what you're trying to do, please provide additional details about: - Screenshots / debug logs / list of commands you've tried to run so far - Your workflow - Current state
j
Hi Luke, your assumption is correct. With fast-forward enabled, Graphite never calls GitHub's merge API, main is fast-forwarded directly, and the PR is closed. GitHub's release notes exclude these closed-but-fast-forwarded PRs. A workaround posted by another user to our Community is https://git-cliff.org/ which generates notes from commits rather than PR status. We haven't formally vetted it, but the approach is sound for this case. That said, we don't provide an in-house solution for this case.
❤️ 1
l
Thanks for the reply Jordan -- will look into git-cliff
Hey @Jordan Toomajon just to follow up since we're on day five of using Merge-Queue, is it also the case that PRs descriptions which link to issues i.e. "Fixes #1234" don't get closed properly because the Merge-Queue closes the PRs (i.e. they don't get merged, so github doesn't close the issue?) Is there a known work around for this?
j
Hey Luke - yes, that's the same trade-off as the release-notes. Because Fast-forward leaves the PR as closed instead of merged, GitHub never fires its "Fixes #1234" event. Let me look into a possible workaround and get back to you shortly.
👍 1
Hey Luke - quick update, I tested the latest with Squash + Fast-forward with the Issue linked in PR description. GitHub did auto-close the issue via the squash commit that Graphite landed on main. So if you saw one stay open, can you send me a link to the Graphite PR so I can inspect from my end?
🏆 1
l
Hey @Jordan Toomajon apologies for slow reply -- looks like merge queue is now working as expected, if may have been a github permission issue on our end (had to approve graphite requested additional permissions to manage github issues). Thanks for looking into this for us though, appreciate it!