did i configure something wrong or is there a bug where graphite can let you merge a PR where it should not be mergeable, and shows "Ready to merge as a stack"? i find that if i merge part of my stack, while it is in the merge queue, it lets me add it to the merge queue even though it doesn't have any approvals? i tested it on these 2 PRs to see if it actually worked or if it would fail, and it did actually merge the PR even though it should not have. https://app.graphite.com/github/pr/lawyai/lawy/3484 https://app.graphite.com/github/pr/lawyai/lawy/3483 notes: • i am a github repo admin, and i am allowed to bypass with a PR and if i manually press the button, but i just pressed the regular "Merge" / "Add to queue" button (and did not press the button that lets me use my repo admin permissions) • i use a github branch ruleset (not classic rule), and graphite is set to be exempt • our github branch protection rule is set to require a PR before merging, and that it requires at least 1 approval (of which the PRs in question have zero)

(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using

gt feedback --with-debug-context <any message>

i have noticed it when merging other partial stacks. i think i got the repro steps right but if/when it happens again i will update

will take a look and get back to you!

This is what it's set to. This is a ruleset not a classic branch rule. As an fyi, our default GitHub branch is

preview

and not

main

(and that's our merge queue branch)

hey ally, i'm unable to reproduce this as an admin in gitub & graphite with the same branch rulesets. do you have another example pr where you're adding to the merge queue w/o any approvals or capture a screen recording?

I think it happened again today but I'll try to get a recording next time I merge part stacks

the ruleset json would be helpful too!

na we don't have the dismiss stale reviews on push enabled

alright Ally, thanks for this. I used the same review ruleset and think ive nailed down a repro. Seems like there is a ~10 second window where if i time my browser refresh properly i can enqueue upstack PRs that havent had approvals. Will flag to the merge team.

In your repro, if you refresh again after that window, does it mean you're unable to enqueue PRs that shouldn't be mergeable? Also, could it be dependent on merge queue duration?

interesting, it could be related, my CI is set to 1 minute wait. I hadnt tried to see how long it stays in that state just meant more there is a window when it can get in that state. Ive also only be able to reproduce 2 out of about 8 attempts so far so still need to nail down exact repro steps, just can confim ive gotten to add things to a queue that didnt have approvals

Ah fair enough. Thanks for working on this! I haven't had to merge any stacks in the last few days but if i do I'll try keep an eye out in case I can get better repro steps, but afaik, what I said initially was all i had to do