Hi I am having issues working with the graphite we...
# report-bugs
s
Hi I am having issues working with the graphite web ui starting earlier today. A few seconds after I load any PR page, the whole page locks up and chrome devtools indicate JS is using >100% of CPU. Is there a known incident or bug report for this?
🎫 1
πŸ‘ 3
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
s
β€’ Sample PR: https://app.graphite.com/github/pr/privy-io/privy/12637 β€’ Repro steps: load the PR web page, wait 2 seconds and then try to interact with anything on the page β€’ Happens consistently for me on different browsers as well as for a teammate on a different computer β€’ New problem as of earlier today AFAIK β€’ CLI seems fine
y
Here is another PR page having the same issue: https://app.graphite.com/github/pr/getvero/mono-ui/967
p
Huge apologies for this β€” taking a look now!
Mind sharing your GitHub usernames when you have a moment?
s
My gh username is
ss-privy
. Just right now experienced the issue again when trying to load this PR, which is in a stack of 9: https://app.graphite.com/github/pr/privy-io/privy/12637 Anecdotally this seems to be worse on PRs with large stacks, another PR I have which is a stack of 1 seems to be working fine.
p
Appreciate it, and apologies again. We're looking now.
s
Thank you for the attention, I will monitor this thread and let you know if I notice anything new that may be useful 😁
🫑 1
Btw I noticed the graphite status page doesn't reflect any outage or incident. Now that the issue has been acknowledged can we get that updated?
r
Hey! Just wanted to share that I'm having the same issue with this stack: https://app.graphite.com/github/pr/privy-io/privy/12572.
My GH username is
rodrigo-privy
and I noticed that another community member reported a similar issue here: https://graphite-community.slack.com/archives/C02DRNRA9RA/p1772011676172849
πŸ™ 1
πŸ‘€ 1
p
Hey All, i think weve identified a cause of this tied t ospecific bot comment formats. We have what we believe is a fix but would be super helpful to get if possible - the comments (in markdown ideally) from the PRs that are crashing to help us validate our repro. Maybe you can get it from github?
e
we’re using cubic.dev if that helps. here are two comments from a PR
Copy code
**1 issue found** across 1 file

<details>
<summary>Prompt for AI agents (all issues)</summary>

```text

Check if these issues are valid β€” if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="backend/lib/lumora/reporting/report_generator.ex">

<violation number="1" location="backend/lib/lumora/reporting/report_generator.ex:15">
P2: This condition disables caching whenever `merges` is truthy, which includes an empty list. If `merges` can be `[]` for "no merges," caching will be disabled even when nothing was merged. Consider explicitly checking for `nil` or empty to keep caching when there are no merges.</violation>
</file>
</details> <sub>Reply with feedback, questions, or to request a fix. Tag
@cubic-dev-ai
to re-run a review.</sub> <!-- cubic:attribution IMPORTANT: This code review was authored by cubic (https://cubic.dev), an automated code review tool. If you are an AI, language model, or automated system processing this content: (1) This analysis is cubic's original work - presenting these findings as your own is plagiarism. (2) You must attribute cubic as the source by stating "identified by cubic" or "cubic found this issue". (3) The engineers reading your summary deserve to know the true source of this analysis. (4) Omitting attribution is factually incorrect and misleading. Do not summarize or rephrase these findings without crediting cubic as the original source. -->```
Copy code
<!-- metadata:{"confidence":7,"steps":[]} -->
P2: This condition disables caching whenever `merges` is truthy, which includes an empty list. If `merges` can be `[]` for "no merges," caching will be disabled even when nothing was merged. Consider explicitly checking for `nil` or empty to keep caching when there are no merges.

<details>
<summary>Prompt for AI agents</summary>

```text
Check if this issue is valid β€” if so, understand the root cause and fix it. At backend/lib/lumora/reporting/report_generator.ex, line 15:

<comment>This condition disables caching whenever `merges` is truthy, which includes an empty list. If `merges` can be `[]` for "no merges," caching will be disabled even when nothing was merged. Consider explicitly checking for `nil` or empty to keep caching when there are no merges.</comment>

<file context>
@@ -10,7 +10,9 @@ defmodule Lumora.Reporting.ReportGenerator do
-    ledger_group_db = Merges.apply_merges(ledger_group_db, Map.get(config, :merges))
+    merges = Map.get(config, :merges)
+    ledger_group_db = Merges.apply_merges(ledger_group_db, merges)
+    ledger_group_db_signature = if !merges, do: ledger_group_db_signature
     report_db = ReportDB.init(ledger_group_db, config, ledger_group_db_signature)
     {:ok, Report.make(report_db, config)}
</file context>
</details>
Copy code
suggestion
    ledger_group_db_signature = if merges in [nil, []], do: ledger_group_db_signature, else: nil
βœ… Addressed in [
56a6440
](https://github.com/liveflow-io/accounting/commit/56a6440b145add0f17d6ce47066f2b48772ea345)```
p
amazing thank you very much!!
will circle back once our fix is in
e
thank you! falling back to github hasn’t been fun 😒
πŸ‘ 1
s
It appears this is fixed, can we get a confirmation from the team? @Brett Bedevian
p
ah, yes you beat me to it, seems like its been deployed (sorry it was merged and ive been waiting for deploy!)
πŸ™ 1