New here to graphite - wondering is there is a set...
# report-bugs
s
New here to graphite - wondering is there is a setting I'm missing or something, but I'm a CODEOWNER and this PR is saying it needs another approver. I've approved the next one up - guessing it's because the base isn't main? PR link. codeowner file:
Copy code
* <@U03G1GQC6V7>
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
hey Sean, if the approval requirements are satisfied then the position in the stack shouldn't matter. Do you know if your membership as a CODEOWNER, or member of a team that's a CODEOWNER, for one of those files has changed recently in GitHub? There can be a sync delay before Graphite is aware of those changes
s
We did have a change, but it was committed early yesterday. FWIW this is what happened to us last time and we had to stop using graphite 😬
p
gotcha, I suspect it could be a matter of waiting for our system's next sync run for it to become aware of that change which should be in a matter of hours
s
okay great - I'll let you know how things progress.
Should this fix existing PRs or will the fix be on new ones?
p
it should fix existing PRs if the root cause is Graphite needing to sync with the changes to the codeowners/team membership. (I recall another case where the root cause was the use of user email addresses when defining the codeowners which we don't yet support, so if that's being done the workaround is to explicitly set the users by username or team instead of email address)
s
We're using github's built in w/ a team reference so that wouldn't be it.
Copy code
* @engineering
Our PRs are still showing as not meeting this requirement.
image.png
I've unchecked "Require review from Code Owners" for now to solve this problem since we're a small team, but I'd really like to get to the bottom of this. I'm happy to hop on a call w/ a graphite team member to debug.
Nvm. I fixed the issue.