I mistakenly kept the setting on in GitHub to requ...
# how-do-i
m
I mistakenly kept the setting on in GitHub to require merge request approval after rebase. This breaks the stack merge because it requires more approval. I changed the setting in Github but it does not change the behavious on graphite for this merge stack. How do I get this merged... its a stack of 21
p
(If applicable) To help us more clearly understand what you're trying to do, please provide additional details about: - Screenshots / debug logs / list of commands you've tried to run so far - Your workflow - Current state
hey Matthew, I suspect this could be due to a delay syncing state between GitHub and Graphite that is eventually consistent. I'm not sure of the ETA of that though, will check with the team. Meanwhile could you please use the
Send feedback
option from in the Graphite app's Help menu (shortcut is
G
then
F
) while on a PR in that stack. That will help us to debug the specific GitHub requirement.
m
@Gareth Brickman would love to if the app was not crashing on me.
p
yeah very large stacks and PRs like that can put a heavy load on the browser (plus whatever other system cpu/memory utilization and constraints are occurring). Your in-app feedback was received!
m
I understand, but that seems like a basic necessity of the tool. Not a fan of excuses, it should just work.
p
It's not intended as an excuse, it's an explanation of why it happens.
m
🙃
My honest feedback is that we found this tool trying to solve handling large code changes. Based on my experience today and your response, I feel less confident in your team's goal to solve this problem. My unsolicited advice is to stress test your system with 20-30-40 stacks with lots of code and make sure it can handle it efficiently. The browser is not the problem, your webapp is not efficient enough to solve the problem.
p
improving the PR page's performance is absolutely our team's goal, and there is active work doing that currently in tandem to having launched the new PR page layout and features. Super users such as yourself are operating it at the P99 🤓