Hi folks, my team makes use of stacked PRs for our...
# how-do-i
m
Hi folks, my team makes use of stacked PRs for our development flow, but when it comes time to merge them they must be reapproved in Github one at a time. Looking at https://graphite.dev/docs/github-configuration-guidelines#required-settings, it looks like we'd need to disable
Require approval of the most recent reviewable push
which is a non-starter for us. We have
graphite app
exempted from our repository settings in github, but that doesn't seem to matter. Is there a way for us to get stack merges to work without completely turning off approvals on Github?
p
(If applicable) To help us more clearly understand what you're trying to do, please provide additional details about: - Screenshots / debug logs / list of commands you've tried to run so far - Your workflow - Current state
hey Marcus, unfortunately not as that is a required setting for Graphite’s automatic management of stacked PRs.
m
are there any recommendations for how to use graphite without allowing people to just merge PRs after CI passes then?
d
@Gareth Brickman, this is a significant concern for your product. I truly appreciate the potential of stacked PRs, which is why I advocated for us to adopt Graphite. However, after using it, I feel it falls short in this area. We've been using Graphite for a few months now, and this issue makes the stacked PRs feature impractical for us. Just imagine having to merge a stacked PR containing 5 PRs and needing to track down 2 team members after each step is merged. It’s frustrating to apologize at every stage for the inconvenience. We attempted to use the custom GitHub action you created, but it introduced additional challenges with keeping PRs updated and led to incorrect dismissals.