Hi! I've added screenshots to a PR (via Graphite) ...
# report-bugs
b
Hi! I've added screenshots to a PR (via Graphite) but they're not visible on our GitHub PR page. This is making Graphite look-bad to my teammates when I'm trying to introduce Graphite to the team. Any tips? Steps to reproduce: 1. Create a PR via Graphite. 2. Edit description in Graphite's webapp, and add a screenshot. 3. Go over to the GitHub PR - the screenshot appears broken. Screenshots of the issue:
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
b
This seems like a regression to me, because I've had no issue with this at either of my previous teams where I used Graphite.
p
Hey Bryan, odd for sure, i cant yet produce in the new or old pr page with a markdown table (i think what youre using here?). Can you share an example PR so i can best understand the settup to reproduce?
b
Hmm, I don't have a public-facing PR for this (it's in a private repo) but if it doesn't reproduce on your end, that's a good sign there's probably something I can do to fix it!
I'll reply here if I get another repro for it
p
the graphite link is fine
p
yea i tried the exact markdown with both a png and jpg and can see the images. Is this happening across browsers?
b
Here's the HTML from GitHub that is broken for me - does this help?
Copy code
<table role="table">
<thead>
<tr>
<th>Parent org (no charts)</th>
<th>Single org (w/ charts)</th>
</tr>
</thead>
<tbody>
<tr>
<td><a target="_blank" rel="noopener noreferrer nofollow" href="<https://camo.githubusercontent.com/98ec2adbd2c2d884d0b389a84c5f21cc04bce8768500bfd5caafc9edf032aa05/68747470733a2f2f6170702e67726170686974652e6465762f757365722d6174746163686d656e74732f6173736574732f66613761353332382d623634332d343436372d386232382d3830383530333738326262612e706e67>"><img src="<https://camo.githubusercontent.com/98ec2adbd2c2d884d0b389a84c5f21cc04bce8768500bfd5caafc9edf032aa05/68747470733a2f2f6170702e67726170686974652e6465762f757365722d6174746163686d656e74732f6173736574732f66613761353332382d623634332d343436372d386232382d3830383530333738326262612e706e67>" alt="CleanShot 2025-10-08 at 09.28.49@2x.png" data-canonical-src="<https://app.graphite.dev/user-attachments/assets/fa7a5328-b643-4467-8b28-808503782bba.png>" style="max-width: 100%;"></a></td>
<td><a target="_blank" rel="noopener noreferrer nofollow" href="<https://camo.githubusercontent.com/d70a67540a83555124f97cdd8fcbff24f83ac6500a277c5543c2386bd676a60f/68747470733a2f2f6170702e67726170686974652e6465762f757365722d6174746163686d656e74732f6173736574732f33336636316263372d383035382d343162652d386164652d3066613533376339306566332e706e67>"><img src="<https://camo.githubusercontent.com/d70a67540a83555124f97cdd8fcbff24f83ac6500a277c5543c2386bd676a60f/68747470733a2f2f6170702e67726170686974652e6465762f757365722d6174746163686d656e74732f6173736574732f33336636316263372d383035382d343162652d386164652d3066613533376339306566332e706e67>" alt="CleanShot 2025-10-08 at 09.28.17@2x.png" data-canonical-src="<https://app.graphite.dev/user-attachments/assets/33f61bc7-8058-41be-8ade-0fa537c90ef3.png>" style="max-width: 100%;"></a></td>
</tr>
</tbody>
</table>
I notice that the
<http://camo.githubusercontent.com|camo.githubusercontent.com>
URLs show "content length exceeded" when I click them, so perhaps that's it?
p
yea, perhaps the file size is too large then. i see we currently dont limit the size of the files on our end but seems like github does
b
ok! I'll give that a shot - thanks!
ok, uploading the images to GitHub fixed the issue - I think you're right about the image-size being the problem! It might be nice to have a setting (or at least warn or something?) if an attachment created in Graphite is unable to display in GitHub. I dunno what'd be involved there but it'd be nice peace-of-mind to not have to check GitHub to see if images render, etc!
p
agreed, I will make sure that gets captured for the team, apologies for the rough experience here but glad youve got it working~
🫶 1
ty 1