Hello! We have a repository where all pull request...
# report-bugs
v
Hello! We have a repository where all pull requests to our main branch require an approval, which we have set as a Graphite Protection. There is a special folder where this requirement is lifted, which we implemented via a GitHub App which approves such pull request in a dedicated GitHub action via the corresponding API. It recently broke: the approval still seems to be received correctly: (1) it is displayed on the GitHub UI and (2) the approval event is shown in the Graphite UI. However, Graphite does not see it as a review approval and also does not allow merging. Could you check what is wrong?
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
v
Graphite UI:
GitHub UI:
The problem happens consistently to everyone and it used to work a few months ago.
Also, I already confirmed that the App has read and write access to pull requests in the repository in question.
p
hey Veronika, thanks for those details. There have been some other reports of bot reviewers recently no longer being detected in the Graphite UI. We will investigate
e
It looks like the bot approvals are correctly being detected again now. Thanks!
p
hey Elliot, could you please double-check in a PR which has a bot reviewer requested/approved with no human reviewer either?
e
@Gareth Brickman yes, that looks like it’s working, e.g. Outwood/app/8225 has just a bot approval and is showing both the approval in the sidebar and classing as being ready to merge
👍 1
v
Thanks for the quick fix, it's working on our side too now!