I just had graphite merge a PR before the required...
# report-bugs
r
I just had graphite merge a PR before the required checks were done, in the new UI, and im not entirely sure how it happened. I can see in the GH that my bypass permissions were used on that PR, but from graphite itself, I just had selected merge when ready. Happy to PR the link to it manually, but I can't see any indication from teh Graphite PR screen that I selected to force push / bypass any controls. It's now happened twice on the same repository, with the same checks (which are mandatory checks on the ruleset). My user has bypass permissions, but I'm not sure why that would affect the default workflow. In GH itself, I have to explicitly select to bypass rules. What information can I provide to help figure out why it happens?
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
p
hey Rory, thanks for those details. Will check in our logs if there's any clues about this
in this dropdown, what was the specific rule bypassed there?
In Graphite UI it's showing all the required checks were successful for that PR. You can click
See details on GitHub
for their logs there:
r
Sorry Im a bit slow with the response. It is showing the job succeeded now, but the merge definitely happened before the mandatory job was merged. the Job was Bazel Build & Test. (See screenshot 3 and 4) In Graphite, it says that PR was finished at 141843. (AEST). (See Screenshot 1) However, if you click on the Bazel Build & Test Link in the screenshot you posted above, it shows that the mandatory step finished running at 042712 (GMT), which is 14:27 AEST - 10 minutes later. (See Screenshot 2) What is strange, is Graphite is showing the status reports for: https://github.com/wayvz-io/network_intent_manager/runs/49464529240 Which is triggered by commit #7188364, but the bypass was against "pushed 0aa0524..52358d2 to main in repo network_intent_manager"
In the PR itself in github, I can see both PRs 7188364 which is before the merge was approved. This was the job that DID run running Bazel Build & Run, but didnt copleted until AFTER the merge (causing the bypass). Then 52358d2 after, which is where Bazel Build & Run were skipped. Im not entirely sure why it skipped. I have a dependency on graphite optimise CI, whcih had skip = false (I dont actually have optimise ci turned on due to some errors i had a while back, and hadnt turned it back on yet) - so maybe something to do with the PR = draft (which doesnt make sense, since it wasnt draft at the time, and the previous step ran it fine, just late)