How do I get a better view of discussions on a PR?
# how-do-i
j
How do I get a better view of discussions on a PR?
đź‘€ 1
ATM I’m finding it really difficult to keep track of the conversation that are happening. In GitHub (and GitLab) you can see code-related conversation in the files view and also on the main summary page.
However, in Graphite these are either on the code (not helpful if I’ve ticked viewed) or in the discussions section in the sidebar. Which is a good start but falls short in a couple ways for me
👍 1
The discussions view in the sidebar would be useful except it shows no form of hierarchy and is difficult to digest at a glance. I always have to click to show all comments, the comments aren’t grouped by discussion so appear in a pseudo-time based order that doesn’t quite match how I would expect and are split up.
The discussions section feels like a notification area more than anything else
Usually I’ll pick up a couple of things during PR review and want to check those items specifically to see replies, but they are hard to keep track of in that view
I imagine if the discussions view in the sidebar grouped things by thread, it’s be easier to see what had happened and click through to the right thing, but it’s hard to tell which things are brand new, which are exisiting. GitHub/GitLab handle this on their conversations view by collapsing resolved threads by default, something like that for the discussion view would help me read it
👍 1
Writing all this - the sidebar feels “claustrophobic” (for lack of a better word). I generally avoid looking at most of it and just look at the top two/three boxes
âž• 2
👍 1
p
This is super helpful feedback! I'm currently in the process of revamping the way that we display blockers + conversations in the side panel (or otherwise), and am keeping a lot of this in mind
I'd also love to get your feedback on some of the designs + to learn a little more about how you review PRs to better inform some of the changes we make here! I'll DM you a link to my calendar if you're able to chat with me for a bit in the next week or so :')
👍 1
t
I'd just like to add a +1 on the sidebar claustrophobia. I often find myself unsure of: • if there was a new comment • if i've read/resolved all threads I frequently feel like conversations are more "lost" than in github.
đź‘€ 1
I'll note that part of the problem is the difference between threads and discussion comments
This is actually a problem with github (and maybe my teammates) that graphite may have an opportunity to improve on. Comments aren't threads, but they often still need to be resolved. Graphite currently puts threads and comments in different sections of the sidebar.
Did you know that all github comments can be resolved? Even if they're not threads. I would love if Graphite made all comments more easily resolvable than on Github.
đź‘€ 2