Graphite Community

Screenshot 2023-09-20 at 4.19.04 PM.png

yep, this looks like a bug! ooc, if you wait a few seconds after leaving the last comment are you able to submit the request changes review?

i can't remember if Github itself makes us either provide 1) a comment body 2) inline pending comments + no body

and whether that's a hard API requirement to be compatible

right i'm just wondering if a request changes with:
• empty body
• no comments
is even legal or if their API just 400s

(not to say we couldn't just fill in the body with some dummy value to get around it, but that'd be something to figure out how to do correctly)

image.png

if you try this on Github, it 400s and gives you an error banner

<@U03RBQVHZE1> I think the issue is that we are posting comments instantly by default (this changed last week), instead of batching comments into a review

if you want comments to batch with your review submission, you can either:
• use the dropdown caret next to the *Post* button to select batching
• use `shift cmd enter` to batch a comment
then you can leave a review without a review summary