This message was deleted.
# feature-requestss
Slackbot
09/19/2023, 11:44 AMThis message was deleted.
v
Vampire
09/19/2023, 12:36 PMUnless something changed, it should only show when focused or hovered with the mouse or you scrolled that far that there is enough space to always show it without obscuring the changes. Otherwise it should just be a button at the bottom
d
David Balatero
09/19/2023, 1:35 PM@Jason Cipriani do you use graphite at a fairly small window height? that might be what triggers the box to always be present
David Balatero
09/19/2023, 1:35 PM(can you make it taller and see if the box starts to auto hide?)
David Balatero
09/19/2023, 1:36 PMalso is there something about your PR being only a 1 line change that makes it ok for the box to show 🤔
👍 1
David Balatero
09/19/2023, 1:36 PM(we can look into both these things but if you still have this open it would help collect more info for the ticket)
j
Jason Cipriani
09/19/2023, 2:16 PMIt seems to auto-hide on my work computer (latest Chrome, macOS), but not on my PC at home (latest Chrome, Windows). When I get home I will test to see if maybe AdBlocker or some other extension is interfering with something.
Resizing the browser window to be smaller on my (working) work computer does not seem to have an effect. I will test with window sizes more when I get home, as well.
Jason Cipriani
09/19/2023, 2:19 PMNo, I take that back. It also fails to auto-hide when looking at this specific PR on my work computer as well. I think it's actually working correctly though and I was just making assumptions about its behavior. It appears that it only auto-hides when the code lines are behind it, so for tall window sizes with short code changes it doesn't auto hide. But also in that case it doesn't actually get in the way of reviews either. So this is a non-issue I think.
Hope that made sense and sorry about that, I think.there's nothing to be changed here. I am new to Graphite and was looking at lots of PRs and kind of just confused myself with what was happening.
d
David Balatero
09/19/2023, 2:20 PMno worries. there is some ambiguity about the behavior of the box, and i'm curious if we've hit the sweet spot there
✅ 1
j
Jason Cipriani
09/19/2023, 2:21 PMI think you got the sweet spot. I'll let you know if I have any more actual issues with it. Thanks!
🙏 2
k
kush
09/19/2023, 3:48 PMfor context, we've tuned the box to auto expand only once you've reached the end of the code (ie. near the bottom of the scrolling container) -- because of this, on shorter PRs it'll open by default!
that said, it should never hide any code lines so please let us know if that happens! glad to hear that it's been hitting the sweet spot for you 🙂