This message was deleted.

Hmm this should be 1:1 with your BPRs in GitHub - is this PR mergeable in GitHub?

Interesting — yes, it is mergable in Github. Perhaps a bug?

Strange! Do you ming linking me to this PR? DM is fine!

@Fravic Fernando was this PR a part of a stack? And do you have branch protection rules on branch it’s merging into? If so, Graphite might be trying to be helpful by projecting your branch protection rules up the stack so that when you go to eventually merge this PR it already has all the requirements met. Eg. main might require 1 or more approvals, but the branches in the stack might not.

^^ Ah, looks like I misspoke - didn't realize this PR was part of a stack. Thanks for the clarification @Xiulung Choy!

Hello! I think you’re right that our main branch does require approvals. I think the issue might be that our approvals are made via a GitHub App (a “Code Review Automation” bot) and that bot approval doesn’t seem to show up in Graphite. So Graphite thinks there are no approvals, but GitHub thinks there are approvals

Oh interesting, is “Code Review Automation” the name of the bot?

It is! It’s an internal app to our org though, so not publicly visible (and perhaps that’s why Graphite can’t detect it)

What does your GitHub reviewers panel look like when the bot reviews the PR? Does the bot show up there?

Yup! The bot shows up in Github but not in Graphite

Awesome, this is really helpful for us to triage. Thanks! In the meantime, do you know why your team uses a bot for approvals?

Thank you, appreciate your help! Yes, we use a bot mainly because we allow developers to submit approvals post-merge, which Github’s UI doesn’t support. (The bot makes automated pre-merge approvals in certain low-risk cases.) I do notice that Graphite’s UI supports post-merge approvals, which is nice! Likely a bit of an edge case

@Fravic Fernando we found what was causing this and have a fix rolling out. Non-user reviewers will soon show up correctly in the reviewers panel. Let us know if you continue to see this issue. Thanks again for helping us to triage!

That’s awesome, thanks a lot @Xiulung Choy and team for your help with this!

All thanks goes to @David Bradford !

Hello, sorry, I have returned! 😅 I see that our code review bot now shows up in the list of approvers, but it doesn’t seem to count towards the

Needs more approvals

check? I’m still blocked from merging the PR via Graphite, even though I can merge on Github

Hi Fravic, I'm taking a look at this issue. I'm working on a fix that should be available later today.

Amazing, thanks again @David Bradford!