This message was deleted.
# feature-requestss
Slackbot
08/15/2023, 3:00 PMThis message was deleted.
a
Aryaman
08/15/2023, 4:02 PMDoes the changes since last reviewed banner not address this use case for you?
Aryaman
08/15/2023, 4:02 PM(Or are you not seeing this banner? In which case it is a discoverability issue or a bug)
t
Tyler Laprade
08/15/2023, 4:03 PMI have not seen that banner - not sure if discoverability or bug. I will keep an eye out for it!
Tyler Laprade
08/15/2023, 8:10 PMI just received a notification that
v2a
Aryaman
08/15/2023, 8:12 PMDid you previously review this PR?
Aryaman
08/15/2023, 8:12 PMOr just view it
t
Tyler Laprade
08/15/2023, 8:12 PMI commented. We typically don’t request changes unless something is incredibly wrong.
a
Aryaman
08/15/2023, 8:13 PMCould you DM org/repo/number
Aryaman
08/15/2023, 8:18 PMI commented. We typically don’t request changes unless something is incredibly wrong.This is fine as long as you have left a review (versus just a timeline comment). Looks like our banners are fighting each other and we show the one that is less important here IMO.
❤️ 1
t
Tyler Laprade
08/15/2023, 8:20 PMIt showed up for
v3v
Vampire
08/16/2023, 10:35 AMI also did not see that banner (or any other banner) on https://github.com/spockframework/spock/pull/1532 when I did the requested re-review.
Unfortunately, now I already approved the PR.
But on that PR I did do a review with requested changes.
According to GitHub I did it "on behalf of spockframework/supporter" if that might be relevant.
I was not even aware of that banner and just selected the versions to compare manually, but just have seen that banner on a different PR I reviewed before.
Vampire
08/18/2023, 6:03 PMNow I also don't see the banner anymore on the same PR I have seen the banner 2 days ago: https://app.graphite.dev/github/pr/spockframework/spock/1692/Add-a-store-to-the-extension-model 😕
2 Views