This message was deleted Graphite Community #report-bugs

Join Slack

This message was deleted.

# report-bugs

Slackbot

07/26/2023, 2:08 PM

This message was deleted.

Ben Jaffe

07/26/2023, 2:09 PM

Here's a screenshot from my colleague (new to Graphite, should have defaults)

Aryaman

07/26/2023, 2:09 PM

Definitely not expected. Could you share a PR org/repo/number where that happened? I can take a look

Ben Jaffe

07/26/2023, 2:10 PM

PR #5494 is by me, and has arapoport3 as a direct reviewer

Aryaman

07/26/2023, 2:11 PM

What is the org/repo

Ben Jaffe

07/26/2023, 2:11 PM

archiveresale

Ben Jaffe

07/26/2023, 2:11 PM

https://github.com/archiveresale/archive/pull/5494

Aryaman

07/26/2023, 2:12 PM

Thanks. Let me take a look. It is possible it is related to this GitHub PR incident, and we aren't getting all the data back from the GitHub API.

Ben Jaffe

07/26/2023, 2:12 PM

here's mine, in case it's helpful

Ben Jaffe

07/26/2023, 2:13 PM

I had this issue several hours ago (it might have been late last night PT actually), before the official start time of the issue.

Aryaman

07/26/2023, 2:14 PM

Looks like this just started though, so if you have been experiencing this for a few days it is more likely on our side.

👍 1

Ben Jaffe

07/26/2023, 2:14 PM

but maybe service was degraded before Github called a sev 🤷‍♀️

Aryaman

07/26/2023, 2:33 PM

It looks like 5494 was approved by

arapoport3

a few minutes ago, and I see it correctly in their

Waiting for author

section. Is there another example I could use to debug? Something that you expect to see in

Needs your review

but isn't there.

Allison Rapoport

07/26/2023, 2:41 PM

oh sorry, I went to it directly via URL and approved (I'm

arapoport3

), but it wasn't showing up before in the

Needs your review

Aryaman

07/26/2023, 2:43 PM

No worries, could you let me know if this happens again? I'll jump on it immediately and debug. I'm unable to reproduce it for myself unfortunately.

Allison Rapoport

07/26/2023, 2:43 PM

yep can do!

Aryaman

07/26/2023, 2:43 PM

Thanks so much to the both of you for reporting these things!

Ben Jaffe

07/26/2023, 2:45 PM

@Aryaman I just added @Allison Rapoport to the PR

archiveresale/archive/5495

. Not sure if it's showing up properly for her, but it might repro the issue...

Allison Rapoport

07/26/2023, 2:46 PM

it looks like that one is working for me

😮 1

Aryaman

07/26/2023, 2:49 PM

Did you re-request Allison on 5494?

Aryaman

07/26/2023, 2:49 PM

Or just regular request

Allison Rapoport

07/26/2023, 3:45 PM

when i review a PR and "just comment", should it then show up in the

waiting for author

section? if so, seems like there may be a bug there with

archiveresale/archive/5495

Aryaman

07/26/2023, 3:47 PM

It should. Let me take a look.

Aryaman

07/26/2023, 3:49 PM

This looks like a bug. Taking a look.

🙏 1

Aryaman

07/26/2023, 3:58 PM

Looks like we're missing your review in our data store, resulting in the filters not working correctly. Trying to figure out why your review is missing in our store.

🔍 1

Aryaman

07/26/2023, 5:54 PM

We've narrowed down, thinking about how to fix. Will keep you all updated. Thanks for the report@

👍 2

Aryaman

07/26/2023, 6:10 PM

Ok this should be fixed now, we got into some really weird state with our cache having the data, but our DB not having it, resulting in us never writing to the DB. This should be fixed for the PR in question now, but we'll investigate why this happened in the first place. Based on the logs it looks like 5495 should now be in `arapoport3`'s "Waiting for author" section.

Allison Rapoport

07/26/2023, 6:53 PM

i see it there now! thanks for the quick fix!

Open in Slack

Previous Next