This message was deleted.

I would say it is personal preference. You can definitely resolve comments with additional commits on the same branch. I generally do an amend workflow, but the tool was built with the intention of supporting both >1 commit branches and single commit branches.

What are the benefits of the amend workflow? The docs say

1. Use 1 commit per branch (not required but strongly recommended)

But amending commits feels worse because you lose information—I like to resolve PR comments by with a comment linking to the fix commit, so reviewers can easily verify, and you can't do that with an amend workflow. So what about the amend workflow makes it strongly recommended?

@Matt Solomon sorry for the delay! So in short, it sounds like you have a clear reason to use multiple commit branches, so please continue to do so! Note that your usecase is also addressed by the versions feature on Graphite, where we highlight the diff between latest and last reviewed version to the reviewer, so they should be able to do this automatically. You as an author can also point this out to them. So while the information is lost on the

git

level, it exists on Graphite level. We'll write something more detailed regarding why we recommend single commit branches and get back to you. My personal reason is that it is I see each branch as an atomic change, and I don't need to further break down this abstraction into smaller pieces. It is also what I'm used to coming from mercurial + phabricator.

got it, thanks for the explanation!