This message was deleted.
# bug-reportss
Slackbot
06/08/2023, 10:45 PMThis message was deleted.
j
Joseph Gilley
06/08/2023, 10:45 PMthe good news is the WIP comment is saved in GH UI
Joseph Gilley
06/08/2023, 10:45 PMso I can resume from there, but scaryyy
m
merrill
06/08/2023, 10:46 PM@David Balatero is working on fixing this!
❤️ 1
d
David Balatero
06/09/2023, 6:41 PM@Joseph Gilley i fixed this partway
• you don't lose any WIP comments or draft comments when a PR author pushes a new commit
• if you switch to the new version:
◦ any draft comments (that you've pushed Post comment or Start thread on and are on Github) will be kept
◦ WIP comments you haven't saved will be lost still 🚨
i will be addressing the remaining WIP comment issue next, but the spookiest behavior (you lose your comments 100% when your coworker pushes) should be fixed
David Balatero
06/09/2023, 6:41 PMi felt it was more important to get this partial fix out than wait on the entire stack of fixes
💯 1
🦸 1
j
Joseph Gilley
06/09/2023, 6:48 PMsiick thank you! GTK about the second scenario but at least that scenario is self-inflicted
d
David Balatero
06/09/2023, 7:36 PMyeah but it's still a potentially easy footgun since we prompt you to click thru to the new version
David Balatero
06/09/2023, 7:37 PMactually we double prompt you which needs some design revisit 😉