This message was deleted.
# how-do-is
Slackbot
06/08/2023, 1:41 AMThis message was deleted.
➕ 1
e
Eddie Dugan
06/08/2023, 9:04 PM@Aryaman maybe you have an idea?
a
Aryaman
06/08/2023, 9:09 PMThis should be in your branch protection rules
Aryaman
06/08/2023, 9:09 PMIn repo settings
e
Eddie Dugan
06/08/2023, 9:10 PMah, yeah we do require that the "last reviewable commit" has an approval, but i don't think that should be clearing all the previous approvals. maybe it's a different setting ....
j
Jacob Gold
06/08/2023, 9:10 PMHi! This is due to the branch protection rule “dismiss stale pull request approvals when new commits are pushed"
e
Eddie Dugan
06/08/2023, 9:11 PMthis is a screenshot of our rules that our admin sent me when i was asking about it yesterday
Eddie Dugan
06/08/2023, 9:11 PMmaybe our repo rules are being overridden by some org-level setting 🤔 🤔 🤔
j
Jacob Gold
06/08/2023, 9:12 PMAh, from the first screenshot it looks like "just-toby" is dismissing this review, not GitHub
e
Eddie Dugan
06/08/2023, 9:13 PMyeah that's me, the PR author
j
Jacob Gold
06/08/2023, 9:13 PMit might be the "most recent reviewable push" one — I think that's a new rule
✅ 1
e
Eddie Dugan
06/08/2023, 9:13 PMfwiw this happened to another PR of mine that i wasn't merging via graphite
Eddie Dugan
06/08/2023, 9:15 PMyeah we have that one set unfortunately 😞 .... is it possible to merge the stack without rebasing/committing to the stacked PRs?
j
Jacob Gold
06/08/2023, 9:16 PMBecause of how Graphite implements stacking on top of GitHub, it does need to change the base branch as we merge each PR in the stack
Jacob Gold
06/08/2023, 9:17 PMAs for the rebase we do, it's not required in some cases (the note on the "rebase each PR before merging" option on the merge UI explains this somewhat), but it seems like these reviewes got dismissed just from changing the base branch
➕ 1
e
Eddie Dugan
06/08/2023, 9:18 PMexactly, the order of comments is super suspicious. it makes it seem like it's just the base branch changing that dismisses the reviews
Eddie Dugan
06/08/2023, 9:19 PMin general, should i expect graphite to be super handicapped by the "last commit" branch protection?
j
Jacob Gold
06/08/2023, 9:25 PMI think so, unfortunately — this is the first case of it I've seen (likely because of how recently they've added this, we haven't had this report before). We can do some testing on our end to verify that this is in fact the issue
❤️ 1
e
Eddie Dugan
06/08/2023, 9:26 PMthanks for the attention
Eddie Dugan
06/08/2023, 9:27 PMit's really unfortunate because we've already tried to convince our security team that this is slowing us down too much, but it didn't make a difference 😞 i was really looking forward to graphite solving some of my issues with github too
Eddie Dugan
06/08/2023, 9:28 PMfwiw i am pretty sure github recently changed to make "base branched changed" fall under this category