This message was deleted.
# how-do-i
s
This message was deleted.
j
https://graphite.dev/docs/merge-queue-faq This one looks interesting.
p
This is an issue we run into as well β€” no one likes pinging reviewers again and again to get re-approvals when merging a stack πŸ˜•
j
Hi! Unfortunately, there is no great way to handle this with stacked PRs on GitHub if it is not possible to change the ruleβ€” our historical answer has been to see if it is possible to disable it. We wish that GitHub would support some sort of customization that let you check which types of changes to a PR resulted in dismissing approvals, but that isn't possible. One thing we've thought very lightly about is a bot that automatically re-approves PRs in this case, but of course you'd need your team to be on board and also making it work with other GitHub branch protections (e.g. required codeowners) might be challenging. Curious if this sounds interesting to either of you though...
d
After I introduced Graphite to our team we had a debate about it cause disabling this rule is not that great of an idea security wise so for now we decided to just try using Graphite with merging stacked PRs one by one. What's interesting is that now we sometimes end up getting on a "pair review" calls that last somewhere between 15-60 minutes where we review either mine or the other person's stack. We haven't timed anything but I noticed that since we started doing this the merging is less painful and is actually faster than before we started using Graphite.
πŸš€ 1
@Jacob Gold the bot idea sounds really cool πŸ‘€ I'd love to have something like that
πŸ‘ 1
πŸ€” 1