we try to check your branch protection rules to know when a PR is fully approved! are you seeing something weird with approval status?
a
Aryaman
03/17/2023, 3:01 PM
Will take in a look in a little bit! AFAIK it is single approval today but should change to being based on the branch protection rule very soon.
n
Nico Gallinal (ReMatter)
03/17/2023, 4:55 PM
I had the filter of PR status not Approved, it had many reviewers and one of them approved it but the filter was not working. that is why I suspect that
a
Aryaman
03/17/2023, 7:01 PM
When you get a chance, can you DM me the org, repo, PR number? I can investigate.
b
Ben Jaffe
03/17/2023, 9:24 PM
I’ve consistently hit this issue, roughly half of my PRs — I think @Jacob Gold had mentioned in a past message something about Github giving back unreliable data from their API, and that possibly being the cause?