What triggers a PR to change status of “Waiting fo...
# how-do-ia
Aaron Hall
04/10/2023, 7:21 PMWhat triggers a PR to change status of “Waiting for review” to “Approved”? I would think it’s the act of hitting approved in the PR, but I have some that still say waiting for review and others that say approved even when I follow the same workflow
p
Pranathi Peri
04/10/2023, 7:24 PMWhat do the PRs say on GitHub?
a
Aaron Hall
04/10/2023, 7:26 PMLooks like approved
a
Aryaman
04/10/2023, 7:26 PM@Aaron Hall it should be:
1. Has >= number of required approvals on base branch from reviewers with write access
2. Has no one requesting changes
Aryaman
04/10/2023, 7:27 PMIf you aren't seeing that, could you msg me the org/repo/number of the PR? I can investigate
a
Aaron Hall
04/10/2023, 7:28 PMSure thing, I’ll message you shortly as I have some I’ve opened and some others have opened
2 Views