Graphite Community

Here's an example screenshot of what this looks like in the Github UI.

Here's an example of what this looks like in Github's UI:

Here's a screenshot of what an error looks like:

And this is the current beta treatment of showing errors/warnings on files not part of the diff:

i actually feel like it must be possible to do this but I'm missing it somehow. looking at the slack channel i'm surprised i'm the first person to mention this

<@U02NRNWC28H> You can actually do this today using the pencil icon next to the status:

The status says "Ready to Merge" but it is still in "Draft" status when I click through.

[Macros] I like the previews after typing `/d` . However, it's pretty small and I sometimes don't know what the image is. Would be great if I could hover to see a larger image

[PR Review] Would be nice to add information about which PRs were already merged in this view:

[Enhancement] It would be great if the PR screen showed emojis. We use them a lot to show the status of the CI in detail, and it would be great to replicate that behaviour:

Screenshots for comparison:

As a first pass, modeling it after how the github UI works would work for me.
Eg - the yellow dot with the other arc moving in a circle around it. Specifics of the UI isn’t super important, but
1. Have the UI automatically update as the jobs finish (probably via polling? See what github does and emulate?)
2. When a job is in progress, show some UI to indicate (eg like the yellow dot in motion).


And here’s what it looks like after it collapses

<@U02QK64RK6J> right now, we've been thinking of editing commit messages for all merge strategies both because we believe it simplifies the mental model and because we also jsut believe it's a better default commit title/message.

Discussing the vanilla "Merge pull request" strategy more in depth, right now, when you "Merge pull request" on GitHub, it looks like the experience you get is very limited:
• a commit title with `Merge pull request #[num] from [repo_name]/[branch]`
• a commit message that is your PR title
Our theory is that replacing that basic experience with a PR title/description by default (plus the PR number) is an improvement as it contains net more information.

fun fact <@U02L87TMPGW>, you can adjust your key repeat speed on macs:

You might have already done this, but if not I’d recommend it :slightly_smiling_face: I cant live without it when coding

It was a little surprising to me, given how key rebases are to the stacks workflow, that rebases are not handled very well in the Graphite UI.

I like how <https://reviewable.io/> handles rebases. The "file matrix tool" allows you to see the state of the PR, including diffs and comments at any point along the timeline of rebases. It shows which revisions have been replaced by rebases, and allows you to select any subset of them to review. It also shows which revisions have actually been reviewed as a reference.

Comments will show inline on rebased code, when it is possible for the system to guess what the comment applies to, with annotations like "Probably rebased from xyz", otherwise they show (IIRC) as orphaned comments.

Here is a screenshot from a review I had lying around with a few annotations:

The interface is definitely more complex, but once learned it is very powerful. As things stand right now I'd still use it over Graphite for the actual review process.