Graphite Community

So when you ignore whitespace the add/remove line counts change (sometimes by a lot if you wrapped a big chunk of code in a conditional or something). It would be nice if these numbers reflected the counts without whitespace

fold and squash are out, i'm coding split as we speak :slightly_smiling_face:

my notes if you're curious :eyes:

Showing warning/error annotations the way Github does would be a huge win. We take warnings into account when reviewing a PR, even if the CI step itself passes. This is the biggest difference that keeps us mostly on Github’s UI. We review there and jump to Graphite to execute merges after approvals happen on Github.

<https://app.graphite.dev/changes-requested#request-o0i0TzYJajcPipNR9wDs>

Here’s an example of a CI check that highlights a potentially dangerous change of introducing a new enum value within a GraphQL schema. This warning doesn’t get surfaced at all in Graphite today.

would be nice to be able to filter PRs in the dashboard by their CI status and separate PR that are waiting for something, with the ones that are ready to be merged

we use <https://github.com/0x00000001A/es6-string-html> to have this beautiful formatting in vscode
If graphite could do something similar it would be so awesome!!!

I’m not a fan of the ligatures in the comment section

dashboard &gt; team insights — would be nice if the chart allowed you to toggle each data series on / off. would be especially useful to toggle off the "team" data line, as it inflates the scale and makes it hard to see individual contributors.

Yup, you should be able to put it back into draft mode after getting reviews to indicate that you plan to make changes.

Right now, it’s pretty unintuitive in our interface but you can change a PR to a draft by editing the status (we’re going to rehaul this UX to be more intuitive soon):

This repo selector makes it a bit annoying to turn on/off repos. Since they are nested into projects, it requires multiple clicks. Particularly annoying if the project (eg get-convex in my SS) has many repos.

In each of the sections, in suggests that my repo selection differs from the default. AFAICT, the only way to switch the dashboard to entirely be looking at a new setup is to go through each section one by one and update the repos selected (which is unwieldy as mentioned above)

Thank you very much

so maybe it is not more new lines but here is an example of previous view, I found it through the youtube view that I start with. now it looks like the second photo. it was 4 lines per commit but now it is 8 lines per commit. I guess it showed the PR information but it is just using a lot of lines. Another options, is, if we can just have a local config file, that we can select not to show certain lines.

Also, as someone color blind, the light PR name are extremely standing out and hide away other information and it feels like these PR # or needs rebase are the most important things on this screen. this is a separate issue tho.

Thank you again.

Hey <@U02RREE9GKH> thanks for the reply :slightly_smiling_face:

Do you have docs on exactly what `gt branch split` does, in terms of git commands? And how to use it effectively, etc?

Also, how can I ensure 3 diff's are merged together? I want to guarantee that if diff A get's merged, diff B does too (ideally in the same branch, so when my manager clicks this "Revert" button on github, it works correctly)

image.png

im curious: are you imagining that this page would show all the code changes, or is there something else that would be valuable to show there (ex. a written title/description of the stack) ?

For now the biggest need is all code changes and (even thought it's mot likely unfeasible) allow commenting on the changes. We have yet to encounter any other specific need for such a page

Internally, we're figuring out if we want to use stacks as their own feature branch of sorts. Seeing all the changes would let us see if anything was forgotten somewhere in the stack more easily. For example, searching for `// TODO` at the end would be helpful.

You can do that with the `--reviewers` flag!

I think `gt mergetool` should redirect the command to `git mergetool`