Graphite Community

image.png

`repo sync` checks if all of the changes in a branch exist in trunk, so if a branch is empty it'll do this — I guess we'd normally expect folks to have a change on the branch before running it, but this is good flag, I'll think about how we can improve!

Yeah makes sense! My normal workflow is to do `gt bco master ; gt rs ; gt bc whatever` but this time I forgot to do the middle bit!

Screenshot 2023-04-06 at 11.12.03 AM.png

Screenshot 2023-04-06 at 11.12.08 AM.png

sorry for the delay here, we’ve got a fix for this rolling out now!

Screenshot 2023-04-07 at 07.07.15.png

thanks! (though FYI the bug i mentioned in the message before this one is much higher-impact)

are you telling me reviewmojis aren’t high impact?? :face_with_symbols_on_mouth:

jk we’re looking into both :slightly_smiling_face:

Screen Shot 2023-04-10 at 11.04.58 AM.png

Screen Shot 2023-04-10 at 11.05.17 AM.png

bumping this, still facing this issue and would really like to be able to modify / turn off notification settings

Hey! Super sorry about that - we're looking into this for you!

Haven't forgotten about you! still looking into this - thanks for bearing with us

hey! really sorry for the delay here — this unfortunately slipped through the cracks a few times

it looks like we misconfigured one of your reminder digests under the hood due to an edge case in a backfill, so i’ve gone ahead and reset it for you

you should be able to edit your digests again, but feel free to lmk if you have any other concerns!

<@U04AP0M9AES> thanks! looks like it's working now
appreciate the help

Loading PRs has been super unstable for me today

Screen Shot 2023-04-10 at 8.11.53 PM.png

Ah thanks for the feedback - looks like things should be up and working now!
We're working on improving messaging/communication when things are down - hopefully this will happen less in the future (with some new changes) and if it does, it will be more obvious why it is happening!

Hi! Could you share your github username so I can debug?

Hi, I added a temporary work around to your filters that should solve this problem for now. Specifically, I removed the "NOT is fully approved". There is a known bug here, that I'm in the process of fixing. I'll add it back in once fixed.

Out of curiosity, does your base branch have required approvals &gt; 0?

If ~so~ not, do you want to see PRs that have "enough approvals" in the "waiting for reviewers" section, even if they are effectilvey "approved"

Yeah, they do. Didn't know about the "enough approvals" though, thanks for letting me know!

FYI: These are the default filters that came with Graphite. I don't think I've made any custom adjustments to this one.

Thanks for the help. appreciate it :slightly_smiling_face:

Yes, we have a known bug! Fixing now. We were just in the process of migrating default filters.

nvm, i was signed out for some weird reason

Thanks for the flag! Will create a ticket for it!

CleanShot 2023-04-12 at 14.40.10.png

cc <@U04HQKF7TSN> who can help debug this!

Hi, I’m planning on shipping a fx for this this week. As a temporary workaround you can delete the “is not fully approved” filter from that section. 

I can also fix for you in an hour or so if you’re unable to get to it by then. 

I merged a temporary fix for this which should deploy in the next hour or two. I'll let you know once it deploys. You should then be able to add the filter back.

Uhm, which ones were that where I should add this again? :innocent: Or can I easily revert my dashboard to the default?

If you want, I can do it for you as well, just need your GitHub login 

There is a regression (maybe). I need to remove "is not fully approved" again in order to see the PRs.

Thanks for reporting, I just made some changes this week. Could you DM me the PRs that are missing and what section they are missing from?

is `gt log` opening in `less`? If so this is expected and should match the `git log` behavior — `q` will exit

Yeah it does open in `less` but this wasn’t the case in 0.18.x I think which is what I upgraded from

We used to not use a pager at all — see <https://graphite.dev/docs/configuration#user-level-configuration> (Pager) for how to either turn the pager off, pass arguments to `less`, or use a different pager entirely

A colleague of mine noticed the same. The list of files in the right-hand bar would be correct, but one of the files did not show in the diff view.

Thanks for flagging! We'll look into this - if you want to DM links to the Graphite PRs feel free and it may help us debug

hey! catching up here, sorry for the delay

we’re extremely sorry that you ran into this problem — this was caused by a bug in our diff rendering logic which we’ve identified and fixed

that fix has been verified internally and will be rolling it out to everyone soon :slightly_smiling_face:

Cc <@U02RREE9GKH> for a quick Chrome Extension fix

<https://graphite-community.slack.com/archives/C02DRNRA9RA/p1681328265636589> looks like its this issue aswell!

thank you for the flag! the fix for this is rolling out as we speak

<https://graphite-community.slack.com/archives/C02DRNRA9RA/p1681359455032689?thread_ts=1681328265.636589&amp;cid=C02DRNRA9RA>

we’re currently only using reactions to notifications for feedback (and not for reacting to messages directly) — but there are plans to change this! stay tuned :slightly_smiling_face:

yup, i reacted with a heart and it worked, but :+1::skin-tone-3: with a skin tone fails

I am using a `git worktree` and both PRs are in the same worktree.

Another peculiarity of my usage recently: I have been using branch names like `amonshiz/linear-ticket-number/foo-bar-baz`. Previously I had a format of `amonshiz/linear-ticket-number-foo-bar-baz`. Is it possible that the extra level of `/` is causing the issue?

Hmm this is interesting
<@U02RREE9GKH> / <@U03Q89DJPL4> potentially!

Any thoughts on this <@U02RREE9GKH> or <@U03Q89DJPL4>? Happy to Tuple or otherwise help debug!

Ahh this bug was crushed during user checkin call - thanks for reporting :slightly_smiling_face:

I just had it happen to a newly created stack :disappointed:

Update: On <@U02RREE9GKH>’s suggestion I used the Graphite CLI option to change the name of the repo locally and that fixed my issue!

does this go away if you refresh the page?

Thanks for getting back <@U02E95J4648>. It doesn’t go away on refresh.

Understood, sorry you’re running into this!

I need to run, but we’ll dig in when we get a chance

<@U02E95J4648>/<@U04HQKF7TSN>: Any updates on this? Can I help by providing a loom video or anything?

Actually, it turned out that the selection of repos for that section (All PRs) was non-default. Those repos did not have any recent commits, which is why the section was empty. Apologies for the false alarm. FWIW, the UI already tries to highlight this, but at least for me it was not prominent enough.

Screenshot 2023-04-14 at 09.38.41.png

it just happened again

here's exactly what happened – all inline comments disappeared (they do reappear on re-load)

upon re-loading – the comment I was rewriting got reset again

really sorry that you ran into this, i know it’s an extremely painful experience  :disappointed:

we’re working on full fledged support for restoring pending reviews and comments in cases like this, but there are some kinks that we’re still working through before it can be shipped — thank you for bearing with us, and we’ll let you know when this is released!

this is a known issue we currently do not support codeowner checks but it is in the works!

Thanks a bunch for flagging <@U051LEHHR2P>!! <@U02DGG322G5> previously fixed a similar issue, I'll also flag this with the team

Sounds great! I’m around if more data is needed

It seemed to be impacting multiple PRs, but as of today, I can’t seem to replicate it. I went through all of the work I did on Friday and CPU usage is pretty stable

I've been trying to repro also but haven't been able to either. This is something we care about so please let us know if you see this again!

Will do! I’ll be sure to note down specifics if it occurs again

Just a CORS issue in the console, but seems irrelevant

I just queued a fix for this to merge. You should see it within the next few hours or so.

Ah, appears to be a Node version issue. Moving Node to v16.20 worked!

<@U03RGJEDWH5> looking, thanks fore reporting

So we changed the definition of approved PRs to be PRs that have &gt;= the number of required approvals as set on the branch protection rules. It looks like for your PRs the number is 0. Hence they show up as approved. What is the behavior you would expect here?

Ah that makes sense, and is a good question! I think Waiting For Review is the appropriate designation because I've requested reviewers

That's reasonable. Let me think a bit more about the right produce experience, and update this.

Hi all! We’re investigating a possible incident that has taken down the site

Graphite - Dashboard failing to load and CLI submits being rejected ​*[Investigating]*​ We are currently investigating this incident.
 ​*Affected:*​
CLI, Dashboard
 View incident