Graphite Community

I'm clicking this `X` to dismiss reviews on my PR but it appears to be a no-op :disappointed:

<@U046AC503K6> Thank you. I solved it without error on console log.

Great question —

When doing a stack merge where:

• A and B are consecutive PRs in the stack
• the same file is modified in both A and B
• either squash-and-merge or rebase-and-merge is selected
Graphite needs to rebase B on top of the trunk branch after merging A, as GitHub is not smart enough to realize there is no merge conflict now that a different commit of A's changes has been committed.*

Now, when we combine this with the GitHub branch protection rule "Dismiss stale pull request approvals when new commits are pushed" (see screenshot), the rebase of B causes the reviews to get dismissed.  We recommend turning this rule off.

And what you're seeing where some branches have their approvals dismissed and some don't is due to only some of your branches changing the same files as others — the ones that don't are not rebased by Graphite.



*this doesn't happen with the standard merge strategy because the exact commit that B is based on is merged into the history of the trunk branch

:+1: this issue just hit me as well, the original comment was just `whitespace only` , upon editing it, the following was shown in the input text area

Oh, now I got this on my second PR in the stack.