Graphite Community

newline github.png

newline graphite.png

this has now been fixed, thanks for your patience!

Screen Recording 2023-07-27 at 13.04.10.mov

HAHAHA omg. Looking into this, thanks for the flag!

CleanShot 2023-07-27 at 14.13.00@2x.png

Oh what the thanks for flagging! I'll see what's going on and fix this :)

Hmm I'm not able to repro, was it transient?

Let's see, might be some privacy extension that is messing things up

Looks like ClipboardItem is behind a feature flag in Firefox: <https://developer.mozilla.org/en-US/docs/Web/API/ClipboardItem#browser_compatibility>

Screen Shot 2023-07-27 at 7.50.27 AM.png

Screen Shot 2023-07-27 at 7.50.10 AM.png

If I un-assign myself from my PR it changes back to normal

Hmm thanks for pointing this out! I'm not sure if we support this functionality yet, but cc <@U0486U7UUF3>

hm the assignee section shouldn't have an affect on the pr author but I can take a look! Do you have a pr that this is happening on?

<@U0486U7UUF3> I imagine it's all of our pull requests, but here's one from Matt that has him assigned to it: <https://app.graphite.dev/github/pr/owner/Owner/3321>

I think I've just put out a fix for this that should land in prod in a few hours! Thanks for reporting!

image.png

<@U0486U7UUF3> I think I'm still seeing this. Four pull requests, all of which I am the author/assignee of, from <https://app.graphite.dev/github/pr/owner/Owner/3398|here> downstack. As the page loads, the :warning: symbol is there, then disappears, then reappears. One time when I refocused the page after it had been loaded for a couple of minutes, the :warning: symbol spontaneously disappeared–but came back after a page refresh.

Hey <@U05G3UQSZ2A> sorry you're still seeing this! I haven't been able to repro this since putting in my fix last week. Can you try hard refreshing to the latest frontend version? Also if you are able to create a steady repro in a test pr for me to dive deeper into that'd be extremely helpful!

<@U0486U7UUF3> I'll hard refresh and create a steady reproduction if I see it again!

<@U0486U7UUF3> Here is a reproduction, I can leave it open for a day or so: <https://app.graphite.dev/github/pr/owner/Owner/3430/>

Thank you so much I'll take a look today!

Update: there was another place I needed to apply the previous fix and it's going out now! Should be available in a few hours! Thanks again for flagging!

CleanShot 2023-07-27 at 16.18.37.png

I can take a look at this. Can you DM me the repo (org and rename) that you are experience this on?

jumps.mov

interesting - does that happen with every comment you hit reply on?

hmmm having trouble repro-ing :disappointed:

i wonder if the height of your window is playing into it

these indicators should change color based on whether the threads are resolved or not! could you try hovering over them to see if the icon matches the state that you expect (resolved vs not)?

if those don’t match up with the state of the comment in the PR, then that’s a bug :bug:

this is the culprit! the file is large, so it was collapsed by default, which means i didn't even see my colleagues comment in the "gutter"

this behavior is really unfortunate, because the changes lines is only like ~30 or so, and this behavior made it seem like I was ignoring my colleague

Do you know if there's a quick fix you'd be able to prioritize? :pray:

aha! great catch

i think in this case we really should be showing you the comments up near the header or something (since the file was automatically collapsed by us, and not you) cc <@U02DCQ1C0G6>

we’ve got some more holistic pr page layout changes coming up in the next few weeks that should also make it easier to interact with discussion on PRs — i’ll see how we can solve this as a part of that work!

Screen Recording 2023-07-27 at 5.13.15 PM.mov

Is there an open ticket for this? Or is this considered correct behaviour?

Sorry, could you give a little more context here? I’m not quite understanding the issue

Screenshot 2023-07-30 at 12.43.44 PM.png

Hey <@U02RREE9GKH>! Thanks for getting back to me. I have create a sample project to demonstrate the issue.

I have a project here called <https://github.com/mmroz/graphite-templates|graphite-pr-templates> this repo has 1 PR template called <https://github.com/mmroz/graphite-templates/blob/main/.github/PULL_REQUEST_TEMPLATE/OPTIONAL_PR_TEMPLATE.md|OPTIONAL_PR_TEMPLATE>.
The docs for PR templates are <https://graphite.dev/docs/creating-and-submitting-pull-requests#using-a-pr-template-for-submissions|here> and it says `The logic mimics GitHub's for the most part`

What happened:
1. When I create a PR using github's web interface I do not see a PR template: <https://github.com/mmroz/graphite-templates/compare/main...pr-no-template-web?quick_pull=1|PR>
2. When I create a PR using `gt stack submit` I see:
    a.  `Edit body` which shows the non-default PR template
    b. `Skip` which uses the non-default PR template
What I expect:
Because there is no default PR template in this project I would expect no pr template

Ah, I see now — seems like we are incorrectly handling a single "optional" template in a `PULL_REQUEST_TEMPLATE` folder the same as a template with the `pull_request_template.md` filename.  Filed a ticket; thanks for clarifying!

Do you have SLA's for requests like this? Its  blocking a project we have ongoing at Block

We don't have tight SLAs yet — we're still quite a small operation with lots to build — but we have recently started prioritizing fixes/features for customers on our enterprise plan!

I think you can change the line <https://github.com/withgraphite/graphite-cli/blob/main/apps/cli/src/lib/utils/pr_templates.ts#L16> to be
```(templateFiles.length === 1 &amp;&amp; templateFiles[0].match(/pull_request_template.md$|pull_request_template.txt$/i) !== null)```
and this should do it.

Full disclosure, I don't do Javascript and I am unable to get `yarn build` to work but _I think_ this would work

Hey! <@U02RREE9GKH> any news on this release?

Hi, haven't had the chance to make this change yet, but will see if we can get that done soon for you!

Congrats on the 1.0.0 release! Did the change make it into the release?

it did! let me know if it works as expected for your case.

Looks like release 1.0.5 hangs when you select no-template with this configuration

Hey, we identified the bug and pushed a fix! look out for it in the next CLI release

Screen Shot 2023-07-27 at 7.54.36 PM.png

We faced an similar issue like 2 hours ago.

Upgrading the graphite CLI to latest and re-generating the token using `<https://app.graphite.dev/activate>` resolved the issue

Hmm unfortunately, that didn't work for me :disappointed:

ok i did nothing but everything works again.

nevermind. it seems to work on already submitted branched but a new local branch gives the original “failed to submit error”

<@U053PUNN4LW> everything seems to work. all i did was update the cli <https://graphite.dev/docs/updating-the-cli>

Hi all, thanks for flagging in this thread. I found a recent bug introduced in our backend logic and just reverted the change — things should now be working again!

2023-07-28 15.15.17.gif

Tried to request two reviewers in the UI today but it freaked out. I don’t know if only requesting one would have made it work, I ended up just pinging the PR to them directly

CleanShot 2023-07-30 at 17.01.35@2x.png

I believe that we simply have not yet incorporated fast-forward into the estimation and that they will all merge at the same time (cc <@U03Q89DJPL4> who can confirm)

Yes. The time estimate are “worse-case” right now, which does not take FF merging into account (it assumes full CI will need to be run serially on each PR). 

Thanks for the note! We'll look into it :slightly_smiling_face:

Are the commits in the git history in the expected order?

We have occasionally been seeing some strange behavior from github, where it takes a surprisingly long time to detect that the PR has been merged. It seems to be really inconsistent. And if it is just the timing of the github merge events that you are seeing, then it is likely related.

I'm currently investigating some other approaches to how we handle merges that I don't think have this problem.

Screenshot 2023-07-31 at 3.20.05 PM.png

Screenshot 2023-08-01 at 7.27.29 AM.png

<@U04K5N14V9B> Hello Pranathi, yes I’m seeing this in the CLI. And it seems to be kinda growing.

I cloned the repo fresh new and created a new stack, but the message persists.

This should be fixed! It was some legacy code/categorization that as left in the CLI

Solved it by completely removing graphite and re-installing it

i believe a fix for this was pushed in the latest cli version!

Screenshot 2023-07-31 at 11.09.42 AM.png

Screenshot 2023-07-31 at 11.08.31 AM.png

Tried refreshing page. Closed browser and reopened. Did not fix it…

<https://app.graphite.dev/github/pr/Lumen-Energy/roofs/4615/MultiUser-invite-model-GQL-etc|this PR> renders as awaiting review in the list view but approved in the detail view

When using the `gt` CLI, I noticed that I cannot set my branch prefix to a string that ends with a `/` (e.g. `hisaac/`). The `/` gets omitted. I am able to use a string that contains a `/` not at the end (e.g. `hisaac/gt`). Is this expected?

Graphite - httpsapp.graphite.devgithubprwhopiowhop7896fix-discord-cancel-error 2023-07-31 at 14.41.41@2x.png

happening when loading PR details too. just very slow

KP on Arc that if you have multiple tabs open, only the first opened one will work properly — the Browser Co team has given us some stuff to try fixing this, we will be rolling it out soon!

workaround is to close all other open graphite tabs

Not 100% sure, but my best estimate is on the order of a few weeks

yep! added this thread to our tracking task

fwiw, I use Arc and this is a daily annoyance for me as well

I wonder if putting Graphite as a Favorite app at the top might help? Those are never frozen or discarded to the best of my knowledge. But I don't think that would prevent other tabs from getting frozen. So maybe not sufficient.

++ i don’t run into issues in arc typically with a pinned graphite tab

and if i do have multiple tabs open and run into this problem, switching to each tab once will ‘unstick’ graphite so that you can continue

#7898 feat add retool data json column to users - Graphite - httpsapp.graphite.devgithubprwhopiowhop7898feat-add-retool-data-json-column-to-users 2023-07-31 at 15.39.43@2x.png

#7898 feat add retool data json column to users - Graphite - httpsapp.graphite.devgithubprwhopiowhop7898feat-add-retool-data-json-column-to-users 2023-07-31 at 15.39.59@2x.png

Hey Jack! Are you still running into issues?

CleanShot 2023-07-31 at 18.43.00@2x.png

Proud of you for listening to the error message directions lol

is this what you see when you navigate directly to `<https://app.graphite.dev/insights>` ?

it appears that you’re hitting our feature gates because you need to be on graphite team in order to filter by specific users in insights — it shouldn’t be possible to get into this state via the free UI

if you are able to consistently get into this state, please lmk the repro steps so that i can resolve this for you!

ah my explanation wasn’t very clear — you should be able to view insights still, but it will be locked to a predefined view that applies across the entire org

sounds like there’s a bug here which i can look into

i bought the team package anyway - i wanted it badly

love that! welcome to graphite team!!

can you confirm that everything works as expected now? either way we'll get the bug fixed asap :slightly_smiling_face: 

cc <@U04K5N14V9B> - might be a quick fix!

Could you try hard refreshing `cmd + shift + r`? Based on our logs I see data being returned here.

I see you in the list. I think it's just bad colors on our part. cc <@U04AP0M9AES> and <@U02DCQ1C0G6>

Oh wow! I didn't see that. Shouldn't it say my name too? It shows the name of other reviewers on PRs

Ah thanks for the flag, will bring it up with team!

There are other parts that get cut off too. But when I mentioned it to <@U02DCQ1C0G6> at a meetup earlier this year it seemed to be a KP :slightly_smiling_face:

you said
&gt; Essentially put a comment on a file in a version and remove the file in an updated version
and the reply button doesn't work

<@U05K9UTHB19> also the comment thread appears underneath one of these stale file headers, right?

also is this on the sidebar, or in the main code diff?

In the sidebar, don't see the "not in latest commit" file

hm, are you viewing the latest version of the PR by chance?

if you refresh do you have the same problem? (refreshing will put you on the latest version, you can also switch versions with the version selector up top)

Screenshot 2023-08-01 at 4.39.00 PM.png

Screenshot 2023-08-01 at 4.38.36 PM.png

Ooh we'll take a look! Could you share a link to a PR over dm?

Screenshot 2023-08-02 at 10.20.55 AM.png

hey! sorry about this, there is a known issue with our feature gating on the insights page affecting some users -- a fix should be available by eod!

the fix for this is on it’s way out to everyone now! please let us know if this still isn’t working for you in a few hours

Graphite - Slack Notifications are being affected by ongoing Slack incident ​*[Investigating]*​ Slack is having an incident <https://status.slack.com/|https://status.slack.com/>. We are continuing to monitor.
 ​*Affected:*​
Notifications
 View incident button