Graphite Community

image.png

If I had to guess, Graphite might think these PRs are still merging because CI on `main` was broken when they tried to merge. Is this a known issue?

(<https://app.graphite.dev/github/pr/archiveresale/archive/3201/bash-sell-flow-some-misc-stuff?panel=info|example PR>)

And if it is a known issue, is there a way to get them out of the list?

Ping in case my message slipped by, <@U04K5N14V9B>

Hi sorry about that! Let me look into it!

<@U045W8WMUN5>, could you send a screenshot of what the filter conditions on this section are?

Screenshot 2023-02-09 at 4.50.07 PM.png

It's possible that the "last updated" condition could be very large in this scenario

Also, is this just a "merging" section or both "merging/recently merged?"

Also I noticed that the alt text for the merged icon says “Merged” in the list.

I see, I think the merging/rebasing filters could be a bit buggy - looking at a fix! Thanks for reporting this!

We killed some jobs last night so this may be fixed!! Let me know if it's still an issue

<https://app.graphite.dev/github/pr/archiveresale/archive/3201|Here’s the bottom link>

<@U04K5N14V9B> Reviving this — is there something I can do to get those old PRs out of the Merging section? The top two are currently merging, but the rest have been there for weeks. I believe they all had CI failures when they landed on `main`, which might be a clue.

IIUC <@U045W8WMUN5> you only want to see the currently "merging" PRs there? And not merged ones?

Or is the issue that a PR failed to merge, and now is stuck in the merging section?

Actually, not quite either. The PRs that are stuck have successfully merged, and graphite knows this (at least in the status icon)

but they merged just fine (we had a CI outage, and the PRs were safe to merge). So it seems like they’re in a weird state on the Graphite side and not getting unstuck. Here’s the section settings, for completeness.

Ah, and these should be filtered our from the `merging` section?

Yes, I’d expect them to not show up because they sucessfully merged.

<@U045W8WMUN5> what is your github handle?

we had some bad rows in the db :grimacing:

I have one remaining issue with all this state around people approving PRs, but they don’t change from “Waiting for reviewers” to “Approved”, but I’m guessing that’s unrelated to this

Does “Review status is: Approved” mean one or more approval?

You should see improvements in the accuracy of the sections coming soon.

I believe for approval status the issue is related to the GitHub API returning an incorrect calculation of whether the PR is accepted — we're improving our own derivations of this sort of thing :slightly_smiling_face:

Now when I re-run `gt dev cache --clear`  I get
```ConcurrentExecutionError: Cannot run more than one Graphite process at once.
    at Object.lock (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/dist/src/lib/engine/cache_lock.js:11:23)
    at Object.handler (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/dist/src/commands/dev-commands/cache.js:20:15)
    at /usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:8891
    at j (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:4956)
    at M.handleValidationAndGetResult (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:8860)
    at M.applyMiddlewareAndGetResult (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:9502)
    at M.runCommand (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:7231)
    at [runYargsParserAndExecuteCommands] (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:57900)
    at M.parseAndUpdateUsage (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:8000)
    at M.applyBuilderUpdateUsageAndParse (/usr/local/Cellar/graphite/0.20.13/libexec/lib/node_modules/@withgraphite/graphite-cli/node_modules/yargs/build/index.cjs:1:7707)```


I eventually found a workaround: recreating a branch `parent-branch` :
`gco -b parent-branch` pointing to `parent-branch-split-2`
made graphite cli operational again

Just cced you because though I eventually found a solution, it looks like there is a bug at cli level :slightly_smiling_face:

Don’t think you got the right person there <@U03JEUESH2B> :wink:

Thanks for reporting, glad you were able to figure it out — we'll look into this!

I tried `gt repo init --reset` that’s not working either

went into my `.git/` hopefully this is helpful:





`.graphite_repo_config`

```{
  "trunk": "master",
  "lastFetchedPRInfoMs": 1675970587082
}```
`.graphite_pr_info`
```{
  "prInfoToUpsert": [
    {
      "prNumber": 77,
      "title": "add dot env config",
      "body": "## Description\nneed environmnetal variables to target development and production builds\n\n## GitHub Issue or Linear Task\nN/A\n## Why is this change required?\nneed to create different builds based off the enviroment the sdk is in\n## How Has This Been Tested?\nran tests locally, they passed\n\n\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/77>",
      "headRefName": "add_dot_env_config",
      "baseRefName": "pull_request_template",
      "isDraft": false
    },
    {
      "prNumber": 78,
      "title": "update tsconfig with incremental",
      "body": "## Description\n<https://www.typescriptlang.org/docs/handbook/compiler-options.html>\n```\n--incremental\t\nboolean\ntrue if composite,\nfalse otherwise.\nSave .tsbuildinfo files to allow for incremental compilation of projects.\n```\n<https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#faster-subsequent-builds-with-the---incremental-flag>\n```\nTypeScript 3.4 introduces a new flag called incremental which tells TypeScript to save information about the project graph from the last compilation. The next time TypeScript is invoked with incremental, it will use that information to detect the least costly way to type-check and emit changes to your project.\n```\ncan ignore the .tsbuildinfo file in git\n## GitHub Issue or Linear Task\n\n## Why is this change required?\n\n## How Has This Been Tested?\n\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/78>",
      "headRefName": "add_incremental_to_tsconfing",
      "baseRefName": "remove_tsconfig_module",
      "isDraft": true
    },
    {
      "prNumber": 62,
      "title": "add publish github workflow",
      "body": "add a workflow to publish and semvar entropyjs package\n",
      "state": "OPEN",
      "reviewDecision": "REVIEW_REQUIRED",
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/62>",
      "headRefName": "add_publish_github_workflow",
      "baseRefName": "master",
      "isDraft": true
    },
    {
      "prNumber": 79,
      "title": "create bundle browser and node configuration",
      "body": "## Description\nentropy-js needs to be built for but nodejs and browser.\n## GitHub Issue or Linear Task\n\n## Why is this change required?\nENT-146\n## How Has This Been Tested?\n- ran tests locally\n- ran commands locally\n\nbrowser scripts still not working because my branch didn't have the correct x25519 module\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/79>",
      "headRefName": "create_bundle_browser_and_node_configuration",
      "baseRefName": "update_tsup_with_config",
      "isDraft": true
    },
    {
      "prNumber": 63,
      "title": "pull request template",
      "body": "\n## Description\nadded a pull request template from here: <https://www.talater.com/open-source-templates>\n\n## Related Issue\nN/A we have been talking about this for a while so, I just did it.\n\n## Motivation and Context\nPR descriptions are either left blank or they're all a bit different which makes review more difficult.\n&lt;!--- Why is this change required? What problem does it solve? --&gt;\nHaving a standard PR template will make getting context for the PR a bit easier for the reviewer. Also, help the developer explain changes.\n\n## How Has This Been Tested?\nwhen opening PR you should see this template\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n&lt;!--- see how your change affects other areas of the code, etc. --&gt;\n\n## Screenshots (if appropriate):\n\n## Types of changes\n\n&lt;!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --&gt;\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n- [x] Documentation\n## Checklist:\n\n&lt;!--- Go over all the following points, and put an `x` in all the boxes that apply. --&gt;\n&lt;!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --&gt;\n\n- [x] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n",
      "state": "OPEN",
      "reviewDecision": "REVIEW_REQUIRED",
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/63>",
      "headRefName": "pull_request_template",
      "baseRefName": "master",
      "isDraft": false
    },
    {
      "prNumber": 75,
      "title": "remove tsconfig module",
      "body": "## Description\nwe don't need to emit common cjs because tsup is doing that for us, can remove this option\n<https://stackoverflow.com/a/61215252/2402958>\n## GitHub Issue or Linear Task\nN/A\n## Why is this change required?\nremove tech debt\n## How Has This Been Tested?\nran tests locally, they passed.\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/75>",
      "headRefName": "remove_tsconfig_module",
      "baseRefName": "add_dot_env_config",
      "isDraft": false
    },
    {
      "prNumber": 76,
      "title": "update tsup with config",
      "body": "## Description\n\nAdd scripts to create production bundles\n\n\n## GitHub Issue or Linear Task\nfixes: ENT-147\n## Why is this change required?\nNeed production version of js\n## How Has This Been Tested?\nCommands run, and test do not break locally, however. I'm having issues up stack with `@polkadot/*` import an `fs` module so this js will likely crash a browser.\n\nThese commands do create bundles, will work in browser once #79 is landed`\n\nCode doesn't break anything in the package, and commands aren't used in actions, yet. \n\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n ",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/76>",
      "headRefName": "update_tsup_with_config",
      "baseRefName": "use_x255_from_git_repo_link",
      "isDraft": false
    },
    {
      "prNumber": 72,
      "title": "use x255 from git repo link",
      "body": "&lt;!--- Provide a general summary of your changes in the Title above --&gt;\n\n## Description\nyarn install and use nodejs build from hard linked repo\nthe github links in the package.json are temp until we can get the x255 PR merged and I can get a PAT from jordo to push modules to github packages\n&lt;!--- Describe your changes in detail --&gt;\n\n## Related Issue\n\n&lt;!--- This project only accepts pull requests related to open issues --&gt;\n&lt;!--- If suggesting a new feature or change, please discuss it in an issue first --&gt;\n&lt;!--- If fixing a bug, there should be an issue describing it with steps to reproduce --&gt;\n&lt;!--- Please link to the issue here: --&gt;\n\n## Motivation and Context\nfirst step in conditional import of sdk to nodejs and web\n&lt;!--- Why is this change required? What problem does it solve? --&gt;\nrun sdk in multiple environments\n## How Has This Been Tested?\nran tests locally\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n&lt;!--- see how your change affects other areas of the code, etc. --&gt;\n\n## Screenshots (if appropriate):\n\n## Types of changes\n\n&lt;!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --&gt;\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n\n## Checklist:\n\n&lt;!--- Go over all the following points, and put an `x` in all the boxes that apply. --&gt;\n&lt;!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --&gt;\n\n- [ ] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n",
      "state": "OPEN",
      "reviewDecision": null,
      "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/72>",
      "headRefName": "use_x255_from_git_repo_link",
      "baseRefName": "add_incremental_to_tsconfing",
      "isDraft": false
    }
  ]
}```

graphite cache persist

```{
  "sha": "f35fecb7ee649ea71e7a4c10f641adf9359455b7",
  "branches": [
    [
      "master",
      {
        "validationResult": "TRUNK",
        "branchRevision": "5f620b49d5382849f93e166d913fe6bb9ceb668c",
        "children": [
          "add_publish_github_workflow",
          "pull_request_template"
        ]
      }
    ],
    [
      "add_publish_github_workflow",
      {
        "parentBranchName": "master",
        "branchRevision": "8deb436b570e2f12d9dd00faa81d1f0efc070dad",
        "prInfo": {
          "title": "add publish github workflow",
          "body": "add a workflow to publish and semvar entropyjs package\n",
          "number": 62,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/62>",
          "base": "master",
          "state": "OPEN",
          "draft": true,
          "isDraft": true,
          "reviewDecision": "REVIEW_REQUIRED"
        },
        "children": [],
        "validationResult": "VALID",
        "parentBranchRevision": "e1637ebfa99fb1b89a4bdf4a6c64341a84936703"
      }
    ],
    [
      "spin-up-testing-env",
      {
        "validationResult": "BAD_PARENT_NAME",
        "branchRevision": "3096e9f0f1cd2bb152d1f448a6610752e813d627",
        "children": []
      }
    ],
    [
      "02-01-update_entropy-metadata.json_to_reflect_core_master",
      {
        "validationResult": "BAD_PARENT_NAME",
        "branchRevision": "b617d0fd9b735f9b4cffede57828db8264fb6b16",
        "children": []
      }
    ],
    [
      "01-30-Add_tests_for_isValidSubstrateAddress",
      {
        "validationResult": "BAD_PARENT_NAME",
        "branchRevision": "d03c3a71e1be34b9c5935da3cf54afb5f229a217",
        "children": []
      }
    ],
    [
      "remove_requires",
      {
        "validationResult": "BAD_PARENT_NAME",
        "branchRevision": "224bedf25e84286ccbc80104aa81c4081df05c11",
        "children": []
      }
    ],
    [
      "pull_request_template",
      {
        "parentBranchName": "master",
        "branchRevision": "e85e488658c6c867f399306fe257a8d5b14ef91f",
        "prInfo": {
          "title": "pull request template",
          "body": "\n## Description\nadded a pull request template from here: <https://www.talater.com/open-source-templates>\n\n## Related Issue\nN/A we have been talking about this for a while so, I just did it.\n\n## Motivation and Context\nPR descriptions are either left blank or they're all a bit different which makes review more difficult.\n&lt;!--- Why is this change required? What problem does it solve? --&gt;\nHaving a standard PR template will make getting context for the PR a bit easier for the reviewer. Also, help the developer explain changes.\n\n## How Has This Been Tested?\nwhen opening PR you should see this template\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n&lt;!--- see how your change affects other areas of the code, etc. --&gt;\n\n## Screenshots (if appropriate):\n\n## Types of changes\n\n&lt;!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --&gt;\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n- [x] Documentation\n## Checklist:\n\n&lt;!--- Go over all the following points, and put an `x` in all the boxes that apply. --&gt;\n&lt;!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --&gt;\n\n- [x] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n",
          "number": 63,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/63>",
          "base": "master",
          "state": "OPEN",
          "draft": false,
          "isDraft": false,
          "reviewDecision": "REVIEW_REQUIRED"
        },
        "children": [
          "add_dot_env_config"
        ],
        "validationResult": "VALID",
        "parentBranchRevision": "5f620b49d5382849f93e166d913fe6bb9ceb668c"
      }
    ],
    [
      "use_x255_from_git_repo_link",
      {
        "parentBranchName": "temp_disable_build_command",
        "branchRevision": "46765a779970fddc495eebafd3ca401528623708",
        "prInfo": {
          "title": "use x255 from git repo link",
          "body": "&lt;!--- Provide a general summary of your changes in the Title above --&gt;\n\n## Description\nyarn install and use nodejs build from hard linked repo\nthe github links in the package.json are temp until we can get the x255 PR merged and I can get a PAT from jordo to push modules to github packages\n&lt;!--- Describe your changes in detail --&gt;\n\n## Related Issue\n\n&lt;!--- This project only accepts pull requests related to open issues --&gt;\n&lt;!--- If suggesting a new feature or change, please discuss it in an issue first --&gt;\n&lt;!--- If fixing a bug, there should be an issue describing it with steps to reproduce --&gt;\n&lt;!--- Please link to the issue here: --&gt;\n\n## Motivation and Context\nfirst step in conditional import of sdk to nodejs and web\n&lt;!--- Why is this change required? What problem does it solve? --&gt;\nrun sdk in multiple environments\n## How Has This Been Tested?\nran tests locally\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n&lt;!--- see how your change affects other areas of the code, etc. --&gt;\n\n## Screenshots (if appropriate):\n\n## Types of changes\n\n&lt;!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --&gt;\n\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n\n## Checklist:\n\n&lt;!--- Go over all the following points, and put an `x` in all the boxes that apply. --&gt;\n&lt;!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --&gt;\n\n- [ ] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n",
          "number": 72,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/72>",
          "base": "add_incremental_to_tsconfing",
          "state": "OPEN",
          "draft": true,
          "isDraft": false
        },
        "children": [],
        "validationResult": "VALID",
        "parentBranchRevision": "c3022635d290496bb33abee5db3148c5ff96cc34"
      }
    ],```

```        "parentBranchRevision": "c3022635d290496bb33abee5db3148c5ff96cc34"
      }
    ],
    [
      "update_tsup_with_config",
      {
        "validationResult": "VALID",
        "parentBranchName": "add_incremental_to_tsconfing",
        "parentBranchRevision": "a4fa4bbc80532627aa14f8f3b0d3e257bf08f5d8",
        "branchRevision": "2614295ef0e0708d478307ca90ebe42481b5f96f",
        "children": [
          "create_bundle_browser_and_node_configuration"
        ],
        "prInfo": {
          "title": "update tsup with config",
          "body": "## Description\n\nAdd scripts to create production bundles\n\n\n## GitHub Issue or Linear Task\nfixes: ENT-147\n## Why is this change required?\nNeed production version of js\n## How Has This Been Tested?\nCommands run, and test do not break locally, however. I'm having issues up stack with `@polkadot/*` import an `fs` module so this js will likely crash a browser.\n\nThese commands do create bundles, will work in browser once #79 is landed`\n\nCode doesn't break anything in the package, and commands aren't used in actions, yet. \n\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n ",
          "number": 76,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/76>",
          "base": "use_x255_from_git_repo_link",
          "state": "OPEN",
          "draft": true,
          "isDraft": false
        }
      }
    ],
    [
      "remove_tsconfig_module",
      {
        "validationResult": "VALID",
        "parentBranchName": "add_dot_env_config",
        "parentBranchRevision": "4a5e2a12d94a6dd675d0f0748a1546b88aee77d7",
        "branchRevision": "de3acaed5148974690d030c437d9d0e34e6755f6",
        "children": [
          "add_incremental_to_tsconfing"
        ],
        "prInfo": {
          "title": "remove tsconfig module",
          "body": "## Description\nwe don't need to emit common cjs because tsup is doing that for us, can remove this option\n<https://stackoverflow.com/a/61215252/2402958>\n## GitHub Issue or Linear Task\nN/A\n## Why is this change required?\nremove tech debt\n## How Has This Been Tested?\nran tests locally, they passed.\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
          "number": 75,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/75>",
          "base": "add_dot_env_config",
          "state": "OPEN",
          "draft": false,
          "isDraft": false
        }
      }
    ],
    [
      "add_dot_env_config",
      {
        "validationResult": "VALID",
        "parentBranchName": "pull_request_template",
        "parentBranchRevision": "e85e488658c6c867f399306fe257a8d5b14ef91f",
        "branchRevision": "4a5e2a12d94a6dd675d0f0748a1546b88aee77d7",
        "children": [
          "remove_tsconfig_module"
        ],
        "prInfo": {
          "title": "add dot env config",
          "body": "## Description\nneed environmnetal variables to target development and production builds\n\n## GitHub Issue or Linear Task\nN/A\n## Why is this change required?\nneed to create different builds based off the enviroment the sdk is in\n## How Has This Been Tested?\nran tests locally, they passed\n\n\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
          "number": 77,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/77>",
          "base": "pull_request_template",
          "state": "OPEN",
          "draft": false,
          "isDraft": false
        }
      }
    ],
    [
      "add_incremental_to_tsconfing",
      {
        "validationResult": "VALID",
        "parentBranchName": "remove_tsconfig_module",
        "parentBranchRevision": "de3acaed5148974690d030c437d9d0e34e6755f6",
        "branchRevision": "a4fa4bbc80532627aa14f8f3b0d3e257bf08f5d8",
        "children": [
          "update_tsup_with_config"
        ],
        "prInfo": {
          "title": "update tsconfig with incremental",
          "body": "## Description\n<https://www.typescriptlang.org/docs/handbook/compiler-options.html>\n```\n--incremental\t\nboolean\ntrue if composite,\nfalse otherwise.\nSave .tsbuildinfo files to allow for incremental compilation of projects.\n```\n<https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#faster-subsequent-builds-with-the---incremental-flag>\n```\nTypeScript 3.4 introduces a new flag called incremental which tells TypeScript to save information about the project graph from the last compilation. The next time TypeScript is invoked with incremental, it will use that information to detect the least costly way to type-check and emit changes to your project.\n```\ncan ignore the .tsbuildinfo file in git\n## GitHub Issue or Linear Task\n\n## Why is this change required?\n\n## How Has This Been Tested?\n\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
          "number": 78,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/78>",
          "base": "remove_tsconfig_module",
          "state": "OPEN",
          "draft": true,
          "isDraft": true
        }
      }
    ],
    [
      "create_bundle_browser_and_node_configuration",
      {
        "validationResult": "VALID",
        "parentBranchName": "update_tsup_with_config",
        "parentBranchRevision": "2614295ef0e0708d478307ca90ebe42481b5f96f",
        "branchRevision": "ad8b30092411f829a9d3b520311c641223634251",
        "children": [],
        "prInfo": {
          "title": "create bundle browser and node configuration",
          "body": "## Description\nentropy-js needs to be built for but nodejs and browser.\n## GitHub Issue or Linear Task\n\n## Why is this change required?\nENT-146\n## How Has This Been Tested?\n- ran tests locally\n- ran commands locally\n\nbrowser scripts still not working because my branch didn't have the correct x25519 module\n&lt;!--- Please describe in detail how you tested your changes. --&gt;\n&lt;!--- Include details of your testing environment, and the tests you ran to --&gt;\n\n## Screenshots (if appropriate):\n\n## Checklist:\n\n- [ ] My change requires a change to the documentation.\n",
          "number": 79,
          "url": "<https://app.graphite.dev/github/pr/entropyxyz/entropy-js/79>",
          "base": "update_tsup_with_config",
          "state": "OPEN",
          "draft": true,
          "isDraft": true
        }
      }
    ]
  ]
}```

after deleting all of the `.graphite` files in my `.git` I was able to reset gt and get it working again

gt-debug

gt-debug-context.json

gt-dev-clear.txt

My gt state is borked. I think it happened after renaming a branch in the middle of a stack with the parent submitted for PR review. From: `feat/reset-email-response` to `feat/XXX-186/reset-email-response` .
```$ gt ls
ERROR: Cannot read properties of undefined (reading 'branchRevision')```
And `gt ls` and `gt branch checkout` don’t draw the same tree.

Running `gt dev cache --clear` worked for me to at least clear the error. Oh, it’s back again. If I untrack the problematic branch the error goes away. But then tracking a new branch shows very limited options:
```$ gt branch track
? Select a parent for fix/XXX-190/user-create-exists (autocomplete or arrow keys) ›
❯   feat/file-rename
    main```

Screenshot 2023-02-08 at 11.42.25 AM.png

<https://graphite-community.slack.com/archives/C02DRNL3HQU/p1675874874253769>

yee; thanks for the quick response :slightly_smiling_face:

This should be resolved :slightly_smiling_face:

yay! looks good on my side :slightly_smiling_face: Thanks for the quick resolution

<@U039TAB40D7> Thanks for reporting this! I am working on some improvements around status checks and it’s possible I accidentally broke it - do you have a PR number I can look at? Feel free to DM me :slightly_smiling_face:

Screen Recording 2023-02-09 at 09.37.09.mov

Ooh thanks for pointing this out! Will file a task to fix this :))

There’s likely a conflict on the upstack branch with what’s on main/downstack after rebase. Does fixing the conflict get you into a bad state?

Disregard — looks like `gt upstack submit` did the trick.

Thanks!

I’d just double check that your state is correct via gt ls and no rebasing is required. 

Although the problem you expected is probably what I’ve worked through for the past hour— resetting all changes from the upstack branch to make this a clean restack on master

Is that the order you expect? Based on your msg above it seems like skin* and new* are related?

No, unrelated. I was moving skin* away from new*

They were connected, but I disconnected them intentionally

Next time you can do gt upstack onto &lt;child&gt; &lt;new parent&gt;

That’s what I did earlier when I started this process, which became like 20 rounds of rebase conflicts

sorry gt upstack onto &lt;parent&gt; while child is checked out

&gt; …gt ls and no rebasing is required
Is there a proper way to do that? Another member on my team merged his downstack branch, then did a rebase/restack from his next branch up in the stack, and then resulted in quite the mess

<@U042Q7DCY59> :point_up::skin-tone-3: is this the process you followed. Wondering if there are any takeaways from this discussion we can try next time

Not sure I fully grasp what happened. But you could do gt repo sync -r, which will then rebase non merged branches onto main. If you want to share the sequence of things that happened I can provide better advice 

Yeah, I’m not sure we used the `-r` flag there. Does that make all the difference?

<@U042Q7DCY59> Have you tried this, by chance? :point_down::skin-tone-3:
```gt repo sync -r```

`repo sync -r` is the same as running a restack command after syncing. if you’re running into having to address the same conflicts over and over again while rebasing, it may be simply due to the number of commits in the branch that had to be rewritten during the rebase… `git rerere` might be helpful for cases like this depending on the nature of the conflicts. 

try clearing indexedDB as a first step.  second step would be checking for any errors in your javascript console

i just deleted cache and it seemed to fix

Thanks for letting us know! Yeah we are working on CI improvements and there could be inconsistent states esp. between what we previously had and what we are doing now. In fact this sounds like it could be one of the cases where we weren’t calculating required CIs correctly. Please feel free to ping if you see any more issues!

Hi Vincent! We'll send a more general message today but in the interest of making more changes and improvememts we've temporarily made merge when ready unavailable and will let everyone know when it's back!

Hey there!
I understand that you are working on merge queues/etc. but this really really was a good feature.

Our CI takes about 20 minutes to run and it makes merging a long stack painful: if you merge the first 2 PRs in a 10 PRs stack for instance, the 3rd one will have "merge conflicts" (which aren't really merge conflicts as when you rebase they auto-solve) but won't be auto-rebased by graphite. So you have to do it manually and re-submit.

cc <@U02RREE9GKH> who can give you a timeline, but we are definitely working on it rn 

We're working on it! The goal is to have a merge when ready beta group up and running in the next 2 weeks or so :slightly_smiling_face:

I've identified the issue, we'll work on getting a fix out!

this was resolved, are you seeing issues with merge?

yeah, turns out it works at <http://graphite.dev|graphite.dev>, but not at github

I had a stack of 2 PRs 2097.1-&gt;main and 2097.2-&gt;2097.1
hit the 2097.2-&gt;2097.1 PR merge on github, which says it’s been done successfully, but 2097.1-&gt;main PR reflect changes in 2097.2-&gt;2097.1 PR only on graphite, not on github

Ping on this, making it hard to use graphite for me

Can you see your repos in the web dashbord?

Figured this out, `name` somehow ended up including owner, removing it (going from `coda/coda` to `coda`) fixed it

Screenshot 2023-02-12 at 16.07.09.png

Screenshot 2023-02-12 at 16.08.11.png

we do try to indent it further, but github's markdown limits the depth — I think we have some changes planned to the stack comment that will make it clear in cases like this

ah, nice - thanks for the quick response!

Screenshot 2023-02-12 at 16.32.44.png

yeah, this is on our radar :slightly_smiling_face:

i’m having this issue with `gt downstack get` too!
```$ git --version
git version 2.25.1
$ graphite --version
0.20.11```
i think i can provide a repro if it helps

Actually it is not minor.
It is not only in the help output.
It is for example also used in the `completion` output and thus that one does not work at all.

To work-around it, you can add  `| sed 's/index.js/gt/g'` inside the shell scritpt that invokes the Graphite CLI.
But of course only if you tend to not have `index.js` in regular output as that would also be replaced. :slightly_smiling_face:

But be aware that this will also have other side-effects like disabling colored output

And it totally breaks the interactive menus, so don't do it unless you use some pty wrapper.

Screenshot 2023-02-13 at 12.03.14 PM.png

Are you typing while uploading an image or anything? There's a chance it could be a weird race condition

Screen Recording 2023-02-13 at 2.35.37 PM.mov

no, just either drag and drop or file upload; I took a screen recording if this helps

Ok this is super helpful, i'll look into this for you!

So turns out that this has to do with mac settings - if you have the option to `show file extensions` off in your system settings, when dragging the image into the description it won't recognize the file type and thus won't render the image

We're working on a fix but in the mean time, this should solve your issue!

Sorry for the confusing copy! The banner just means that you won't be able to see stats for your teammates who aren't on Graphite until we make some changes.

As for the error you're seeing, cc <@U04HQKF7TSN> who can debug!

thanks for the report! <@U03A1SPV44A> could you dm a screenshot of what you're seeing?

I got past the repo issue -- I had to go into my Graphite "Account Settings &gt; Manage GitHub access" and re-enable the app.  (I was looking around the docs for some mention of the app, because I couldn't find it in the GitHub Marketplace, but found nothing.)

That, and selecting all the users and correct breakdown fixes all the questions I had!  Ty!

Hmmm, restarted my network and it's back working. Bit weird given it wasn't working on mobile hotspot either

Ah, this is a case of an ongoing issue that I'm currently working on a fix for! (AWS has decided to start double running our lambdas more often and we're not idempotent as we should be :sweat_smile: )

Ah alright, good to know y’all are looking into it!

CleanShot 2023-02-14 at 10.23.44@2x.png

For now we don't support `xcodeproj` files and will likely show them in a similar format to auto generated files from now on - but something we're looking at!

But the content is not loading at all. That is a problem. I'd much rather the file load with no syntax highlighting than not be able to view the content at all. :confused:

Gotcha - I'll chat with the team about this!

merge stack.png

We’ve temporarily made merge when ready unavailable while we address some of the instability - we’ll message out once it’s back. Cc <@U02RREE9GKH> / <@U03Q89DJPL4> for viz

We're introducing a beta group for MWR! Be sure to react to/respond in the thread to be included :slightly_smiling_face:
<https://graphite-community.slack.com/archives/C02DRNL3HQU/p1683923375949469>

hi everyone! you may have noticed that `merge when ready` is no longer an option when using the Graphite UI. this is NOT a bug - in the interest of making improvements to the merge process as a whole, we've *temporarily* `made merge when ready` unavailable. we'll let everyone know when it's back in business!! :saluting_face::laptop_parrot:

merge is a little flaky right now while <@U02RREE9GKH> is making some changes! this could be related

Graphite dashboard very slow to load, merging a stack of 3 PRs doesn't do anything...

apologies for the poor experience. cc <@U03Q89DJPL4> who is working on improving our error handling.

Hi Kevin, I'm sorry you hit this. I'm looking into improvements for issues like this. Could you send me more details on the errors you have been hitting? For example, are you seeing any error message pop up, are there any error messages in the console or network tab?

i’ll keep an eye out if they show up again. Thanks!

Hey <@U03A1SPV44A> are the missing committers Graphite users? if they don't use Graphite we aren't able to get insights for them until we make some changes over the coming weeks.

Your laptop change should not affect this. But we did roll out some changes to insights that result in the limitation of supporting only people who have Graphite accounts.

For the old engineers, they used to be graphite users; they are not currently.  (My other laptop still shows them, though. Unless you just changed this in the last week.). I'll ask for the missing current engineer; he's on the dropdown on my other laptop, but maybe he hasn't used graphite recently.

ah i think i know why your older laptop shows them but the new one doesn't. it's likely cached on your browser.

regarding why the engineer is missing, we get the typeahead information from github's repo membership. did the missing engineer lose permissions in the repos?

The missing engineer did not lose permission in the repo.  But I just heard back from him, and he hasn't logged into graphite in quite a while.  When he's back at his computer, I asked for him to login to see if that will add him back to the dropdown.

sounds good. let me know what happens. we should be rolling out some changes next week that should make the dropdown a lot more complete, and include users who don't use graphite as welll.

hey <@U03A1SPV44A>, FYI these changes should be rolling out now. It is dependent on a sync job, so you may see things be out of sync sometimes, but should have better coverage for all users most of the time. Let me know if you see otherwise.

Screenshot 2023-02-14 at 10.01.57 PM.png

Screenshot 2023-02-14 at 10.02.57 PM.png

ah, found the bug! thanks for reporting :slightly_smiling_face:

Awesome, thanks for the super-quick response and fix!

thank you for reporting! looks like we inadvertently borked PAT update as part of a github authentication refactor (the codemod assumed that we wanted to use the user's existing token in all callsites :confused: — now i'll be up checking we didn't do this anywhere else)

<@U02RREE9GKH> I know this is kind of old but I'm still seeing this exact same behavior today. Is there some debugging I can do to help with this issue?

hmm interesting -- will take a look for you!

Sorry it wasn't working on one of your PRs, and thanks for the feedback :)) cc <@U02E95J4648>

We can probably just make the call with the editor open instead of saved to fix! :slightly_smiling_face:

Yeah. Honestly, usually it’s like 80% correct and 20% wrong, so being able to proofread / fix / improve before saving would let me cover the last 20%

<@U047KHH8JH3> is working on improvements here!

Briefly (he can correct if I'm getting anything wrong), GitHub's API vends us incomplete/incorrect data on CI runs, which is why we sometimes get mergeability wrong today, and the panel on the PR page now uses our recalculated value.

I'm sorry you hit these issues. I've been working on some updates that will start to cache the comments while they are being edited, then if anything happens while you are editing, we will still have the content available and be able to recover it. There are still a few kinks to work out, but it should be enabled soon. I'll let you know when it is available.

i'm guessing you've  already down `gt downstack get` and that didn't work?

`gt dev cache --clear` should fix this issue!

If you remember what commands you had run before, that would be helpful to try to figure out where the bug happened

Thanks, I was able to fix it with `gt dev cache --clear` and then using `gt branch track` to reestablish tracking.

Then it happened again-- I’m almost certain that what causes this is either amending or adding a commit in the middle of `gt branch edit`, i.e. using `edit` on one of the intermediate commits during the interactive rebase session opened by `gt branch edit`.