Graphite Community

Hey <@U04HDKVMYKE> sorry you encountered this. When you look at the pull requests on Graphite do you see the comments? 

Looking into this too! <@U04HDKVMYKE> can you share with us your github username so we can hunt down what went wrong?

Hi <@U04HDKVMYKE> - I found your session in our logs. What I see:
• A handful of mild secondary rate limits regarding graphite polling for CI.
    ◦ Question - do you recall how many concurrent Graphite tabs you had open?
• I see that fetching some PRs in your session took up to 10 seconds, which is in our p99 for request times.
    ◦ I dont yet know why this specific load was so slow for you, but we’ll keep digging.
• I see several network requests to create review comments, but from our logs Im not seeing those requests having failed. So that I can narrow the search, can you tell me what PR number your comments failed to post on?
Thanks for your help debugging! I’d love to get to the bottom of this and save you + other from this sort of experience in the future.

Screenshot 2023-06-14 at 5.02.34.png

Hi there! Are you still running into this?

image.png

Hi! Transparently I don't know how high this is on our roadmap given the extensive work we're doing with the web app, but I'll let <@U02RREE9GKH> respond

something that is in my general bucket of CLI polish work, which I am prioritizing for later this summer

Amazing, and thanks for setting expectations!

apparently `gt rs` does:
```git pull --ff-only```
which doesn't <https://git-scm.com/docs/git-pull/2.34.0|fetch the repo>:
&gt; --ff-only
&gt; Only update to the new history if there is no divergent local history. This is the default when no method for reconciling divergent histories is provided (via the --rebase=* flags).

Currently the behavior of only fetching trunk is intentional (`-r` doesn’t change this) — we’re looking at allowing repo sync to update all branches, which is a change that should be rolling out in the next couple of months. (getting the behavior exactly correct for stacks was historically the blocker)

OK thanks! I will tell my coworker to `git fetch` regularly then!

That's definitely not expected! Can you DM the org and repo that you are looking for with the dates

hmmm, seems like it might require a similar fix to what <@U05597DUYDD> is working on for what happens when the code changes

hey <@U0466L39TT7>, i have a fix for this in the deploy queue, so next time production deploys it should be out!

Screen Shot 2023-06-14 at 2.22.33 PM.png

Thanks for the flag! We'll take note of this

I am getting this same issue despite having my name and email in git config.

glad you like the concept! we want to make sure this works for you every time -- is this always off? or are there some specific circumstances when this happens?

Cc <@U04AP0M9AES> - another good fix to this component!

<@U02RREE9GKH> is there someone that's able to help me with this? I'm not sure how to proceed and don't want to screw up a stack we've been working on for months :laughing:

hmm, we should sync that automatically.  does repo sync fix the issue?

I assumed that it would be synced automatically

I just went through the process again, synced repo, restacked the stack, verified his changes are in his branch and tried to submit

Screen Shot 2023-06-15 at 11.56.55 AM.png

I've bee having him cancel here because I don't want our PRs messed up, any idea whats going on?

and that’s the exact same name as the remote branch?

Screen Shot 2023-06-15 at 12.02.39 PM.png

Hmm, well GH has an invariant that only one PR can open per branch/target at a time,  so submitting as normal should be fine

Okay, we can try to do that and update you with the results

Should I have him run `gt track` or anything?

it seems like gt is just not tracking that the PR has been created

tracking is just for the branch, not the PR — from what I'm understanding, the branch is already tracked

It seems like theres an issue with his authentication

cant see PRs in gt dashboard or anything either

I suppose I'll have him try to add a personal access token.

It's odd that none of us (to my knowledge) had to do that though

&gt; cant see PRs in gt dashboard or anything either
ah, it's this

Adding a PAT seems to have worked for the dash

the background fetch for PR data requires us to be authenticated, running repo sync again will trigger it as well

repo sync didn't work

Adding a PAT seems to have worked for both his CLI and dashboard

idk if this is a bug with the oauth/github auth or what

I'm going to be improving the GitHub access settings page next week as part of our hackathon, there are weird edge cases with permissions/repo access that we don't surface well at the moment

Thanks! He's all set as of now, using the PAT

Ooh thanks for flagging - we'll look into it

This is likely an authentication issue, especially if it's only affecting certain repositories.  Any pattern as to which it affects? i.e. repos in specific orgs, public vs. private, etc

Both the repo that’s working and the repo that isn’t working are private repos in the same org.

have any of the repos been renamed since you started working in them?

Can you DM me your GH login and the names of both repos?

Yeah, same here: <https://graphite-community.slack.com/archives/C02DRNRA9RA/p1686307606224319?thread_ts=1686307606.224319&amp;cid=C02DRNRA9RA|https://graphite-community.slack.com/archives/C02DRNRA9RA/p1686307606224319?thread_ts=1686307606.224319&amp;cid=C02DRNRA9RA>

Thanks for flagging guys! We'll look into this

CleanShot 2023-06-16 at 21.22.26@2x.png

CleanShot 2023-06-19 at 08.11.58@2x.png

I've tried authenticating by installing the Graphite app in my GitHub org, and by using a personal access token. Both methods appear to have worked to log in, but I can't get past that error message. Nothing is loading for me.

Ooh that's super strange, sorry this is happening! Looping in <@U02DGG36CSH> and <@U04HQKF7TSN> who may know what's going on here

Checking in here. Anything updates? I'd really love to give the tool a try!

Ok, so it looks like we're seeing authentication errors from GitHub. I'm going to reset you into onboarding. Can you try logging in &amp; setting up again? We recommend using the app for authentication, or OAuth if not, and PAT as last resort.

Just wanted to pop in here one more time to say that I'm really liking things so far. Great work to all involved!

Hi there! Thanks for the report - we're considering moving this from the PR's metastatus into a warning near the branch information on the header. Would this solve your issue?

Maybe, hard to tell until people ask me questions about it. :slightly_smiling_face:

+1 on this. The “needs more approval” section reviewer list ordering jumps around a lot

Gotcha, will message this thread when we've fixed the issue :))

Hi there! Sorry this is happening - we'll take a look for you!

<@U04K5N14V9B>, have you check about this?, I am still getting this issue and now it is not creating a PR, only pushing the branch into Github.

Hi there! Sorry about the delay, we've seen 502s in the past with people that have issues with their auth/access token

Could you try resetting your graphite auth or access token?

Hi <@U04K5N14V9B>, I did the authentication and updated the version, and started getting this error when run, when  call
```gt stack submit```
the error
```
ERROR: Unexpected server response (500).

Response: {
  "_response": {
    "size": 0,
    "timeout": 0
  }
}```


Also, it is not creating an PR, only pushing the branch.

<@U04K5N14V9B>, will you please help me with this?

Hi there, sorry about the delay!!
That's really weird....I'll have to loop <@U02RREE9GKH> into this one

Hi <@U02RREE9GKH>, will you please help with this issue I am facing?

<@U03JZ3FJK88> do you mind sharing your GitHub handle btw? I can also help take a look from our logs and try to get to the bottom of what’s happening

Thanks <@U02DGG36CSH>, here is my username raviraj5

Perfect — I see some interesting error logs. <@U03JZ3FJK88> do you also mind sharing the most recent PR org/repo/number that you tried submitting (and failed)?

sorry for the delay <@U02DGG36CSH>, Here are the PR details in format org/repo/pr-number  vayafintech/aya-apis/#1069,

Mostly for the last month, I getting errors,  firstly got 502, but at that time it was creating a PR, but now started getting 502 and it not creating a PR

<@U02DGG36CSH> do you found anything about this error?

Hey <@U03JZ3FJK88>, sorry about the extended delay here :(( our team has admittedly been really busy the past couple of days
Nick should be able to take a look by EOD!

hey <@U02DGG36CSH>, is there any update or workaround here? I've been seeing the same error and have been blocked from submitting PRs for the last two days as a result. My github handle is mds1, repo is private though otherwise I'd share that too, but let me know if there's anything else I can do to help/get unblocked!

In case it helps, figured out the issue for my case: <https://graphite-community.slack.com/archives/C02DRNRA9RA/p1688588987205259?thread_ts=1688400156.936939&amp;cid=C02DRNRA9RA>

Great to hear and thanks for the update/details <@U05FFD6EPFW> . We’ll do some work to try to detect that case and add some more helpful error logs!

<@U03JZ3FJK88> I found a bug when digging in and deployed a fix. Give submit a shot and let me know if it works!

Yeah, sure. Thanks <@U02DGG36CSH> for the update.

<@U03JZ3FJK88> I saw you ran into another error with submit this morning and I merged another fix. Fingers crossed that this should be it — thanks for bearing with us :slightly_smiling_face:

Hey, <@U02DGG36CSH>, I have tried again and still facing the same issues, I also have updated the graphite version to 0.20.22.

<@U03JZ3FJK88> I found another silly bug :see_no_evil: I’m merging the fix now so let me know if you keep running into this (give it about an hour or two to finish deploying)!

<@U02DGG36CSH>, it's working fine :tada: and thanks a lot for fixing these issues

Glad to hear it! Thanks for the patience and helping us troubleshoot!

Screenshot 2023-06-21 at 8.55.23 AM.png

It seems like after a recent update to some styling the description tab content overflows when there is anything large like before and after pictures

Hm, I just submitted a one-diff stack with `gt ss` and it worked fine (it was submitted correctly) except that CLI output was for the previously submitted stack (which happened yesterday):
```gt ss
🥞 Validating that this Graphite stack is ready to submit...

✏️  Preparing to submit PRs for the following branches...
▸ anton06-16-api_client_prev_stack_description (Create)
✔ Title … api, client: prev stack description
✔ Body › Edit Body (using vim)
✔ Submit › Publish Pull Request

📨 Pushing to remote and creating/updating PRs...
anton06-16-api_client_prev_stack_description: <https://app.graphite.dev/github/pr/>&lt;company&gt;/request-portal/&lt;previous PR ID&gt; (created)```


It should sync. Can you DM me:
1. Your github username
2. A PR you expected to see on your dash and you didn't see
I'll debug from there

Thanks for flagging! We'll take note of this in future CLI updates

this happened to me a whole lot with `gt branch submit` as well. I would mess up the PR title badly by trying to edit it

Is the UI having issues? Its not loading for me, tried both in Arc and Safari

Screenshot 2023-06-21 at 4.20.53 PM.png

Hi Anton, we are working through an incident, we should be recovered now. Can you please hard refresh and confirm if you are still impacted?

Hi there! Still running into this? I believe we had an incident that might have been causing this that's now resolved

Yes, just got it again a moment ago. Looks like it’s auth-related; would it be useful for me to try reauthenticating, or do you want me to not do that so I can help troubleshoot? (I can use the GitHub CLI temporarily, so either way is fine with me.)

It seems to be working now. I didn’t reauthenticate.

Sorry about that, might have been related to the incident. Let us know if it's still happening!

I did the following
1. Had four PRs A -&gt; B -&gt; C -&gt; D
2. did a `gt downstack edit` to change it to `B -&gt; A -&gt; C -&gt; D`
3. `gt stack submit` - and  `B` ended up closed and 403'd the request.

I may just be getting 403s all the time. Not sure.