Graphite Community

Linebreaks are not properly rendered in description.
Just have a look at <https://app.graphite.dev/github/pr/spockframework/spock/1675> if you can.

Update: Actually also in comments, not only in the description, so probably more a general problem of the markdown renderer opposed to Gfm

chrome_RjOkGihUur.gif

The distortion isn’t intended, we’ll look into a fix for this

Following up here, images and videos uploaded from GitHub should now render correct on Graphite PRs - please let me know if they’re still not working for you!

hmm I can’t even run `gt repo init --reset` without it erroring :upside_down_face:

After some snooping I renamed `.graphite_repo_config`  and got to the initialization stage but when I chose `master` as my trunk it ran into the same issue, I guess something must be messed up with my local repo?

Anyway ended up just having to pull a fresh repo and starting from scratch I guess

I’m also getting this error (`git merge-base ...`, `fatal: Not a valid commit name`)-- it started showing up when I did a `git reset HEAD~1` on a branch.

Can’t run either `gt repo sync` or `gt branch checkout`-- seems every `gt` command is broken.

The errors were referencing a branch I hadn’t even operated on recently. I deleted the branch (with plain `git branch -D`) and now the errors have disappeared.

CleanShot 2023-06-01 at 21.38.16@2x.png

thanks for flagging! were there other mentions in reviews left on that PR?

No not in that PR. It was only accepts with no comments. 

got it, thanks for the info! we’re looking into this

Hey Puneeth, what is your GitHub handle? I think you might not have received the newest updates. If so, do you mind if I reset you to the default filtering experience?

We made a bunch of changes to the filtering experience, but held out people whohave changed their filters from these updates. I want to migrate you to the newest default experience.

Just performed the migration. Let me know if you continue to see these issues.

Console says:
```main.4c782e34.js:2 MB: Cereal [__ListPage:section_prs] is failing retype validation {serverId: 'hC4kV4Mk9vMOFw41UYWA_undefined_10_sort-title-ASC', sectionId: 'hC4kV4Mk9vMOFw41UYWA', sortMethod: 'title', sortOrder: 'ASC', __first: '10', …}items: Array(10)0: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…d BlockListener support...","linesChanged":"927"}', selfCursor: '{"prId":"4280631611","updatedAt":"2023-05-07T05:44…d BlockListener support...","linesChanged":"927"}', nextCursor: '{"prId":"4280635517","updatedAt":"2023-05-05T15:24…rable interaction matching","linesChanged":"190"}', payload: {…}}nextCursor: "{\"prId\":\"4280635517\",\"updatedAt\":\"2023-05-05T15:24:32.420Z\",\"createdAt\":\"2023-05-05T15:24:31.741Z\",\"title\":\"Added configurable interaction matching\",\"linesChanged\":\"190\"}"payload: {serverId: 'PR_kwDOABG6hs5KKIBC', githubId: 'PR_kwDOABG6hs5KKIBC', url: '<https://github.com/spockframework/spock/pull/1575>', title: 'Add BlockListener support...', stack: {…}, …}selfCursor: "{\"prId\":\"4280631611\",\"updatedAt\":\"2023-05-07T05:44:08.456Z\",\"createdAt\":\"2023-05-05T15:23:12.309Z\",\"title\":\"Add BlockListener support...\",\"linesChanged\":\"927\"}"serverId: "get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{\"prId\":\"4280631611\",\"updatedAt\":\"2023-05-07T05:44:08.456Z\",\"createdAt\":\"2023-05-05T15:23:12.309Z\",\"title\":\"Add BlockListener support...\",\"linesChanged\":\"927\"}"[[Prototype]]: Object1: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…rable interaction matching","linesChanged":"190"}', selfCursor: '{"prId":"4280635517","updatedAt":"2023-05-05T15:24…rable interaction matching","linesChanged":"190"}', nextCursor: '{"prId":"4280635508","updatedAt":"2023-05-05T15:24…ng the official singing keys","linesChanged":"7"}', payload: {…}}nextCursor: "{\"prId\":\"4280635508\",\"updatedAt\":\"2023-05-05T15:24:32.420Z\",\"createdAt\":\"2023-05-05T15:24:31.741Z\",\"title\":\"Add notice regarding the official singing keys\",\"linesChanged\":\"7\"}"payload: {serverId: 'PR_kwDOABG6hs4da8xJ', githubId: 'PR_kwDOABG6hs4da8xJ', url: '<https://github.com/spockframework/spock/pull/1219>', title: 'Added configurable interaction matching', stack: {…}, …}selfCursor: "{\"prId\":\"4280635517\",\"updatedAt\":\"2023-05-05T15:24:32.420Z\",\"createdAt\":\"2023-05-05T15:24:31.741Z\",\"title\":\"Added configurable interaction matching\",\"linesChanged\":\"190\"}"serverId: "get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{\"prId\":\"4280635517\",\"updatedAt\":\"2023-05-05T15:24:32.420Z\",\"createdAt\":\"2023-05-05T15:24:31.741Z\",\"title\":\"Added configurable interaction matching\",\"linesChanged\":\"190\"}"[[Prototype]]: Object2: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…ng the official singing keys","linesChanged":"7"}', selfCursor: '{"prId":"4280635508","updatedAt":"2023-05-05T15:24…ng the official singing keys","linesChanged":"7"}', nextCursor: '{"prId":"4280718176","updatedAt":"2023-05-05T15:53…the state of the variable…","linesChanged":"211"}', payload: {…}}3: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…the state of the variable…","linesChanged":"211"}', selfCursor: '{"prId":"4280718176","updatedAt":"2023-05-05T15:53…the state of the variable…","linesChanged":"211"}', nextCursor: '{"prId":"4280635509","updatedAt":"2023-05-05T15:24…ning sequences of closures","linesChanged":"151"}', payload: {…}}4: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…ning sequences of closures","linesChanged":"151"}', selfCursor: '{"prId":"4280635509","updatedAt":"2023-05-05T15:24…ning sequences of closures","linesChanged":"151"}', nextCursor: '{"prId":"4280635503","updatedAt":"2023-05-05T15:24…Add TempDir cleanup switch","linesChanged":"193"}', payload: {…}}5: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…Add TempDir cleanup switch","linesChanged":"193"}', selfCursor: '{"prId":"4280635503","updatedAt":"2023-05-05T15:24…Add TempDir cleanup switch","linesChanged":"193"}', nextCursor: '{"prId":"4280635512","updatedAt":"2023-05-05T15:24…on is thrown while polling.","linesChanged":"69"}', payload: {…}}6: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…on is thrown while polling.","linesChanged":"69"}', selfCursor: '{"prId":"4280635512","updatedAt":"2023-05-05T15:24…on is thrown while polling.","linesChanged":"69"}', nextCursor: '{"prId":"4280631631","updatedAt":"2023-05-05T15:23…buddy from 1.12.17 to 1.14.2","linesChanged":"2"}', payload: {…}}7: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…buddy from 1.12.17 to 1.14.2","linesChanged":"2"}', selfCursor: '{"prId":"4280631631","updatedAt":"2023-05-05T15:23…buddy from 1.12.17 to 1.14.2","linesChanged":"2"}', nextCursor: '{"prId":"4280628587","updatedAt":"2023-05-05T15:22…rprise from 3.12.4 to 3.12.6","linesChanged":"2"}', payload: {…}}8: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…rprise from 3.12.4 to 3.12.6","linesChanged":"2"}', selfCursor: '{"prId":"4280628587","updatedAt":"2023-05-05T15:22…rprise from 3.12.4 to 3.12.6","linesChanged":"2"}', nextCursor: '{"prId":"4280631632","updatedAt":"2023-05-05T15:23…version from 4.0.5 to 4.0.10","linesChanged":"2"}', payload: {…}}9: {serverId: 'get_section_prs_item_hC4kV4Mk9vMOFw41UYWA_{"prId":…version from 4.0.5 to 4.0.10","linesChanged":"2"}', selfCursor: '{"prId":"4280631632","updatedAt":"2023-05-05T15:23…version from 4.0.5 to 4.0.10","linesChanged":"2"}', nextCursor: '{"prId":"4280634023","updatedAt":"2023-05-05T15:24…y-plugin from 3.0.0 to 3.1.0","linesChanged":"2"}', payload: {…}}length: 10[[Prototype]]: Array(0)sectionId: "hC4kV4Mk9vMOFw41UYWA"serverId: "hC4kV4Mk9vMOFw41UYWA_undefined_10_sort-title-ASC"sortMethod: "title"sortOrder: "ASC"__first: "10"[[Prototype]]: Object```


These 6 PRs break it: <https://github.com/spockframework/spock-example/pulls>
Without them, the error does not come.

Each of them individually triggers the bug

Fixed by <@U04HQKF7TSN> in <https://graphite-community.slack.com/archives/C02DRNRA9RA/p1685719855503669>

Was able to repro, and looks like we indeed do not save sort order on sections. Will add it to the roadmap!

This has been implemented! cc <@U04HQKF7TSN>

Screenshot 2023-06-02 at 10.48.34 AM.png

With which browser and how does the page source look for you?
For me it is
```&lt;img src="<https://camo.githubusercontent.com/a8b5f6726de4903e6ce89df24ad596326aa4f49974dbb99137f93e280f30421c/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667>" height="34" align="absmiddle" alt="Reviewable" data-canonical-src="<https://reviewable.io/review_button.svg>" style="max-width: 100%;"&gt;```
and both, Chrome and Firefox properly handle the height attribute.

Then I assume an Arc bug. :slightly_smiling_face:

I would be surprised since I don’t think we muck with CSS or the renderer :-/

Well, he didn't say what the source looks for him, maybe GitHub delivers something different, but I'd doubt it :slightly_smiling_face:

I do wonder if maybe different extensions are at work here. I can check on desktop in a few, on my phone currently. 

CleanShot 2023-06-02 at 19.21.44@2x.png

Well, then maybe some setting or plugin for <@U04K5N14V9B> :shrug:

Thanks again for flagging! We'll add this to the roadmap

Screenshot 2023-06-02 at 8.30.16 AM.png

Also getting some console logs about a section PR validation failure

Didn’t work :confused:
I’ve also tried logging out, clearing the site data and logging back in.

just as an FYI: looking at the cereal errors, the data for my sections is there in the `items` array but its just not rendering in the UI

I have a hypothesis. Do you mind if I reset your dashboard sections to defaults? Or do you have something configured there

I have sections configured but I can always redo them :slightly_smiling_face:

Might be the same or related to <https://graphite-community.slack.com/archives/C02DRNRA9RA/p1685705799106969>

Looks like my sections have reset but I’m still getting the same errors

(tried clearing cache and site data again as well)

FYI I took a backup of your filters so I can revert back to that once we're done debugging

Just to make sure.
If it is the same issue as mine (getting the same error in the console),
then I already tracked it down to the concrete individual PRs that cause the bug. :slightly_smiling_face:

<@U05447TKZKP> what is your github handle?

Nvm, found it, let me make sure it's the same issue

<@U048CANQBGU> I have to make some updates to your RQ state to get better logs -- specifically unselecting some repos. I'll reset state after debugging. So if you see anything wonky that is why.

FWIW <@U05447TKZKP> I do think it's the same issue

Oh, this might actually be similar to what I'm getting in the thread below.

Thanks for reporting! We've found the cause, and are fixing it right now.

This fix just hit prod, let me know if you continue to see it

:heavy_plus_sign: also seems to be working now. Thanks!

image.png

Not sure if this is the right way to report- but sometimes I get empty dropdowns for all the items on the `Merging and Recently Merged` screen. I pulled up the console in my screenshot if that helps. Is this an issue on my side?

Saving insights views is coming very soon!

Screen Recording 2023-06-02 at 12.20.08 PM.mov

Ah weird, thanks for flagging! We'll look into it as soon as we can

no.mov

similar but different misbehavior, i guess in both cases from auto complete

Two issues here:

1. If you open the dashboard section settings, remove a filter condition, but then press "Cancel" I expect nothing to be changed,
but the filter removal is persisted.

2. Even though the filter removal was persisted, the section is not showing the updated content.

For comparison here Graphite and GMail in 500%

Graphite - Graphite is down due to a scheduled DB upgrade ​*[Resolved]*​ This incident has been resolved.
 ​*Affected:*​
Dashboard, CLI, Notifications,
 View incident button

cc <@U02DCQ1C0G6> — I imagine that we shouldn’t be applying this to code?

Hey <@U05447TKZKP> thanks for calling this out. .1px might not seem like a lot but it does impact legibility and density across a full line of code.
But ultimately if it’s breaking ligature display then it should be turned off. I’ll make a note to disable letter spacing for ligature enabled fonts

<@U04AP0M9AES> for vis

Thanks for flagging! There's a few click-able elements inside the reviewer item (poke, remove reviewer), but you're right that the row itself doesn't have a click function

Yeah, I've seen the remove, hence I didn't include it in the red border. :slightly_smiling_face:
I didn't see the poke yet, but it's probably not there as I'm the reviewer, I see it where another user is the reviewer.

What does the "poke" do exactly?
It's not mentioned in the docs.

Ah yeah poke is a new feature we released during hackathon! If you have slack notifs enabled, you'll get a notif when someone pokes you and on what PR they poked you on. You can also see it in the notification bell popover in case you don't have slack notifs enabled

Ah, so no additional GitHub comments or something like that, thanks

<https://app.graphite.dev/github/pr/spockframework/spock/1665/> shows in the timeline
&gt; 1 new commit
&gt; commit:
&gt; Add option to scan parameters and fields...
&gt; added <https://github.com/spockframework/spock/commit/21d22acd89273b87bc6ab0e724bc9ee8be63ab7b|21d22a> a few seconds ago
But the "a few seconds ago" is a bit an understatement.
It is about 2_461_392 seconds ago. :slightly_smiling_face:

Sorry you’re running into this! How large is your stack you’re submitting?

It’s happening to every stack, and on multiple machines 

Also happens on stacks that are 2 PRs big

I’ve noticed a behavior where the first PR is always creates but it fails right after. So we have to submit multiple times to get the stack fully pushed 

you may have `alias gt=git` set somewhere in your shell profile

I thought so too but I haven’t found it. However, it’s Monday…let me look again? :sleuth_or_spy:

What what?!
```gt is an alias for git tag```


Ooooohhhhh man…it was buried in zprezto :see_no_evil:

lol zsh plugins and options eventually break all the things, in the fullness of time

```~ ❯❯❯ gt --version
0.20.19```
Now we’re cookin’! Thanks <@U02HMBYM7LL>

Ooh thanks for flagging this - I think this should be an easy fix but I'll double check

cc <@U04AP0M9AES>

Gotcha - we have plans to change the visual model for multi-select settings in general!

Changes display is inconsistent between main view and files sidepanel.
In case there are only added lines, the file panel only shows `+20`, while the main area shows `-0/+20`.

cc <@U05597DUYDD> who was playing with the shortcut

Re: #2, we do have a beta for auto merge if you do want to opt in. cc <@U02RREE9GKH>

i'd love to opt in! i think i was in it previously but then i think the feature was rolled back?

<@U03RGJEDWH5> it is unintentional, i will fix soon. I changed the shortcut to `L + G` but the key registration broke

we'll keep it as `L + G` fyi, sorry about the muscle memory adjust :confused:
but the rationale if you're curious is that `G` is a prefix that means `go` and in this case we're not _going_ to github we're `Copying a [L]ink to [G]ithub`, and that was causing some confusion with others ("shouldn't `g` go to github?")

Sorry for that, one voice was mine :slightly_smiling_face:
Also because it was not in the keyboard help with the other G+ ones

yeah, i'll make sure &amp; add it to the keyboard help as well

the help already shows the new shortcut, just doesn't work :slightly_smiling_face:

Well, the other way around would be more handy :-D

tbd on when it lands; i'm also working on fixes for
• private github images 404ing on graphite
• when someone pushes a new commit to graphite in the middle of you writing a comment it blows away your comment and you lose it (small % race condition, but bad nonetheless)

but i'm hoping the kb shortcut registration is a quick fix

Thanks for flagging! I think this will be introduced whenever we create links/permalinks to comments in the Graphite UI (on our roadmap)

Hmm thanks for flagging this - seems like a bug. We'll look into it to see if we can repro

Hi there! Sorry about that - are you still seeing missing notifications, or was this a one-off situation?

ephemeral -- usually graphite gets me what i need ^.^

Might have been related to an incident that day, but thanks for reporting! Let us know if it happens again